From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LYSgC-0005Vf-BF for qemu-devel@nongnu.org; Sat, 14 Feb 2009 17:08:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LYSg9-0005VT-NZ for qemu-devel@nongnu.org; Sat, 14 Feb 2009 17:08:07 -0500 Received: from [199.232.76.173] (port=45412 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LYSg9-0005VQ-J6 for qemu-devel@nongnu.org; Sat, 14 Feb 2009 17:08:05 -0500 Received: from yw-out-1718.google.com ([74.125.46.153]:38513) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LYSg9-0002WI-9I for qemu-devel@nongnu.org; Sat, 14 Feb 2009 17:08:05 -0500 Received: by yw-out-1718.google.com with SMTP id 6so1688716ywa.82 for ; Sat, 14 Feb 2009 14:08:04 -0800 (PST) Message-ID: <499740A8.3090502@codemonkey.ws> Date: Sat, 14 Feb 2009 16:07:36 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Support multiple VNC clients References: <4995CECB.1070401@moose.net> In-Reply-To: <4995CECB.1070401@moose.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Brian Kress wrote: > Attached is a patch that allows qemu to support multiple vnc clients. > Each client can have their own > VNC encodings and VNC state. > > General idea: > > Change structure associated with a display from VncState to a new > structure VncDisplay. Remove client specific fields from VncDisplay. > Remove display specific fields from VncState. > Maintain a linked list of VncStates per VncDisplay structure, update > as necessary. > When updates/resizes/copies come in from the hardware, dispatch to all > clients. > > > Patch is against current SVN (6618) > Any ideas/suggestions/comments/flames appreciated. Can you add a Signed-off-by line? The patch looks good to me. Regards, Anthony Liguori