qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cory Fields <FOSS@AtlasTechnologies.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add args for quiet and prompt
Date: Sat, 14 Feb 2009 19:07:28 -0500	[thread overview]
Message-ID: <49975CC0.9000305@AtlasTechnologies.com> (raw)
In-Reply-To: <49974565.6010706@codemonkey.ws>

> 
> This all looks like 2-space tabs, QEMU uses 4-space tabs.  I'd suggest 
> factoring this out into a separate function too.
> 
> Regards,
> 
> Anthony Liguori
> 

Just sent out a patch to fix vl.c before i noticed your suggestions. 
Will fix whitespace and move into a new function.

Cory Fields

  reply	other threads:[~2009-02-14 23:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12  6:48 [Qemu-devel] [PATCH 0/4] Cory Fields
2009-02-12  6:48 ` [Qemu-devel] [PATCH] Define a new route for sending data to bios Cory Fields
2009-02-12  6:41   ` Gleb Natapov
2009-02-12 15:50     ` Blue Swirl
2009-02-12  6:48 ` [Qemu-devel] [PATCH] Add args for quiet and prompt Cory Fields
2009-02-12 10:42   ` Kevin Wolf
2009-02-14 22:27   ` Anthony Liguori
2009-02-15  0:07     ` Cory Fields [this message]
2009-02-12  6:48 ` [Qemu-devel] [PATCH] enable quietbios and biosprompt checks Cory Fields
2009-02-14 22:28   ` Anthony Liguori
2009-02-15  0:09     ` Cory Fields
2009-02-12  6:48 ` [Qemu-devel] [PATCH] enable quietbios check Cory Fields
  -- strict thread matches above, loose matches on Subject: below --
2009-02-14 23:57 [Qemu-devel] [PATCH 0/4] Option to suppress bios output and prompt (v2) Cory Fields
2009-02-14 23:57 ` [Qemu-devel] [PATCH] Add args for quiet and prompt Cory Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49975CC0.9000305@AtlasTechnologies.com \
    --to=foss@atlastechnologies.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).