From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LYTct-0001QT-7D
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 18:08:47 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LYTcs-0001Oz-1c
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 18:08:46 -0500
Received: from [199.232.76.173] (port=43484 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LYTcr-0001Oi-Si
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 18:08:45 -0500
Received: from mout.perfora.net ([74.208.4.195]:51226)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <FOSS@AtlasTechnologies.com>) id 1LYTcr-0001X5-Ht
	for qemu-devel@nongnu.org; Sat, 14 Feb 2009 18:08:45 -0500
Message-ID: <49975CC0.9000305@AtlasTechnologies.com>
Date: Sat, 14 Feb 2009 19:07:28 -0500
From: Cory Fields <FOSS@AtlasTechnologies.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add args for quiet and prompt
References: <1234421329-8119-1-git-send-email-FOSS@AtlasTechnologiesInc.com>	<1234421329-8119-3-git-send-email-FOSS@AtlasTechnologiesInc.com>
	<49974565.6010706@codemonkey.ws>
In-Reply-To: <49974565.6010706@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> 
> This all looks like 2-space tabs, QEMU uses 4-space tabs.  I'd suggest 
> factoring this out into a separate function too.
> 
> Regards,
> 
> Anthony Liguori
> 

Just sent out a patch to fix vl.c before i noticed your suggestions. 
Will fix whitespace and move into a new function.

Cory Fields