From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LZ4x5-0007o8-Ap
	for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:00:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LZ4x2-0007nB-Sn
	for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:00:07 -0500
Received: from [199.232.76.173] (port=39325 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LZ4x2-0007n7-K3
	for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:00:04 -0500
Received: from e39.co.us.ibm.com ([32.97.110.160]:54802)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LZ4x1-00027K-S1
	for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:00:04 -0500
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com
	[9.17.195.227])
	by e39.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n1GEvVQi028667
	for <qemu-devel@nongnu.org>; Mon, 16 Feb 2009 07:57:31 -0700
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n1GExu0U188438
	for <qemu-devel@nongnu.org>; Mon, 16 Feb 2009 07:59:56 -0700
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n1GExtct027555
	for <qemu-devel@nongnu.org>; Mon, 16 Feb 2009 07:59:55 -0700
Received: from squirrel.codemonkey.ws (sig-9-65-85-240.mts.ibm.com
	[9.65.85.240])
	by d03av04.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	n1GExsRc027506
	for <qemu-devel@nongnu.org>; Mon, 16 Feb 2009 07:59:55 -0700
Message-ID: <49997F50.9020608@us.ibm.com>
Date: Mon, 16 Feb 2009 08:59:28 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix hardware accelerated video to video
	copy	on Cirrus VGA
References: <49979F23.6010500@moose.net>
In-Reply-To: <49979F23.6010500@moose.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Brian Kress wrote:
>    cirrus_do_copy() in hw/cirrus_vga.c seems to make some incorrect 
> assumptions about video
> memory layout.  It tries to convert addresses to coordinates assuming 
> that one row of data is
> (width * depth) bytes long.  The correct way seems to be to use the 
> pitch fields in the
> CirrusVGAState structure instead.
>    Without this patch, I get lots of screen corruption when I try to 
> drag a window under X as it's
> passing the wrong coordinates to the display surface for the copy.  
> With this patch I can drag a
> window with no screen corruption.

Applied.  Thanks.

Regards,

Anthony Liguori