From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LZ4xI-0007ve-M4 for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:00:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LZ4xH-0007u6-1p for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:00:20 -0500 Received: from [199.232.76.173] (port=39332 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LZ4xG-0007u2-FS for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:00:18 -0500 Received: from e31.co.us.ibm.com ([32.97.110.149]:57372) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LZ4xF-00029h-NE for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:00:18 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e31.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n1GEvq7E018941 for ; Mon, 16 Feb 2009 07:57:52 -0700 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n1GF0EFC197460 for ; Mon, 16 Feb 2009 08:00:14 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n1GF0EW4029629 for ; Mon, 16 Feb 2009 08:00:14 -0700 Received: from squirrel.codemonkey.ws (sig-9-65-85-240.mts.ibm.com [9.65.85.240]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n1GF09hQ028578 for ; Mon, 16 Feb 2009 08:00:10 -0700 Message-ID: <49997F5F.9050704@us.ibm.com> Date: Mon, 16 Feb 2009 08:59:43 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Support multiple VNC clients References: <4995CECB.1070401@moose.net> <499740A8.3090502@codemonkey.ws> <49976C39.10301@moose.net> In-Reply-To: <49976C39.10301@moose.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Brian Kress wrote: > Anthony Liguori wrote: >> Brian Kress wrote: >>> Attached is a patch that allows qemu to support multiple vnc >>> clients. Each client can have their own >>> VNC encodings and VNC state. >>> >>> General idea: >>> >>> Change structure associated with a display from VncState to a new >>> structure VncDisplay. Remove client specific fields from VncDisplay. >>> Remove display specific fields from VncState. >>> Maintain a linked list of VncStates per VncDisplay structure, update >>> as necessary. >>> When updates/resizes/copies come in from the hardware, dispatch to >>> all clients. >>> >>> >>> Patch is against current SVN (6618) >>> Any ideas/suggestions/comments/flames appreciated. >> >> Can you add a Signed-off-by line? >> >> The patch looks good to me. > > Attached. Applied. Thanks. Regards, Anthony Liguori