From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LZ5bB-0001WP-L2 for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:41:33 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LZ5b8-0001VO-S1 for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:41:33 -0500 Received: from [199.232.76.173] (port=45185 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LZ5b8-0001VJ-Ke for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:41:30 -0500 Received: from e36.co.us.ibm.com ([32.97.110.154]:47775) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LZ5b8-0005e5-8W for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:41:30 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e36.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n1GFeMtN021792 for ; Mon, 16 Feb 2009 08:40:22 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n1GFfLAj225190 for ; Mon, 16 Feb 2009 08:41:21 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n1GFfIBj005246 for ; Mon, 16 Feb 2009 08:41:19 -0700 Message-ID: <49998902.4010306@us.ibm.com> Date: Mon, 16 Feb 2009 09:40:50 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qemu: change the pc pci mapping to start from 0xc0000000 References: <1234406198-14094-1-git-send-email-ieidus@redhat.com> <1234406198-14094-2-git-send-email-ieidus@redhat.com> In-Reply-To: <1234406198-14094-2-git-send-email-ieidus@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Izik Eidus Izik Eidus wrote: > This is needed in order to allocate more memory to pci devices > > One side effect of this is that non-pea guests cant see more than 3giga > of ram anymore. > > (vbe really sstart at 0xc0000000, pci start right after that) > > Signed-off-by: Izik Eidus > --- > hw/pc.c | 6 +- > hw/vga_int.h | 2 +- > hw/vmware_vga.c | 4 +- > ...ge-pci-mem-address-to-start-at-0xc0000000.patch | 79 ++++++++++++++++++++ > pc-bios/bios-pq/series | 1 + > 5 files changed, 86 insertions(+), 6 deletions(-) > create mode 100644 pc-bios/bios-pq/0011-bios-change-pci-mem-address-to-start-at-0xc0000000.patch > > diff --git a/hw/pc.c b/hw/pc.c > index 57ba803..e26e2b5 100644 > --- a/hw/pc.c > +++ b/hw/pc.c > @@ -771,9 +771,9 @@ static void pc_init1(ram_addr_t ram_size, int vga_ram_size, > BlockDriverState *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; > BlockDriverState *fd[MAX_FD]; > > - if (ram_size >= 0xe0000000 ) { > - above_4g_mem_size = ram_size - 0xe0000000; > - below_4g_mem_size = 0xe0000000; > + if (ram_size >= 0xc0000000 ) { > + above_4g_mem_size = ram_size - 0xc0000000; > + below_4g_mem_size = 0xc0000000; > } else { > below_4g_mem_size = ram_size; > } > diff --git a/hw/vga_int.h b/hw/vga_int.h > index f97e98f..57f20bf 100644 > --- a/hw/vga_int.h > +++ b/hw/vga_int.h > @@ -59,7 +59,7 @@ > #define VBE_DISPI_LFB_ENABLED 0x40 > #define VBE_DISPI_NOCLEARMEM 0x80 > > -#define VBE_DISPI_LFB_PHYSICAL_ADDRESS 0xE0000000 > +#define VBE_DISPI_LFB_PHYSICAL_ADDRESS 0xC0000000 > > #ifdef CONFIG_BOCHS_VBE > > diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c > index d1cba28..5ee0ad6 100644 > --- a/hw/vmware_vga.c > +++ b/hw/vmware_vga.c > @@ -118,14 +118,14 @@ struct pci_vmsvga_state_s { > # define SVGA_IO_BASE SVGA_LEGACY_BASE_PORT > # define SVGA_IO_MUL 1 > # define SVGA_FIFO_SIZE 0x10000 > -# define SVGA_MEM_BASE 0xe0000000 > +# define SVGA_MEM_BASE 0xc0000000 > # define SVGA_PCI_DEVICE_ID PCI_DEVICE_ID_VMWARE_SVGA2 > #else > # define SVGA_ID SVGA_ID_1 > # define SVGA_IO_BASE SVGA_LEGACY_BASE_PORT > # define SVGA_IO_MUL 4 > # define SVGA_FIFO_SIZE 0x10000 > -# define SVGA_MEM_BASE 0xe0000000 > +# define SVGA_MEM_BASE 0xc0000000 > # define SVGA_PCI_DEVICE_ID PCI_DEVICE_ID_VMWARE_SVGA > #endif > > diff --git a/pc-bios/bios-pq/0011-bios-change-pci-mem-address-to-start-at-0xc0000000.patch b/pc-bios/bios-pq/0011-bios-change-pci-mem-address-to-start-at-0xc0000000.patch > Can you please split this into a separate patch and CC bochs-devel? Regards, Anthony Liguori