From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LZ5hc-0004D7-7K
	for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:48:12 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LZ5hZ-0004Bp-LG
	for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:48:10 -0500
Received: from [199.232.76.173] (port=34213 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LZ5hZ-0004Bl-H1
	for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:48:09 -0500
Received: from e4.ny.us.ibm.com ([32.97.182.144]:54739)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LZ5hZ-0006BS-7i
	for qemu-devel@nongnu.org; Mon, 16 Feb 2009 10:48:09 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n1GFjuhM021605
	for <qemu-devel@nongnu.org>; Mon, 16 Feb 2009 10:45:56 -0500
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n1GFm5Aj192010
	for <qemu-devel@nongnu.org>; Mon, 16 Feb 2009 10:48:05 -0500
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n1GFkvew003079
	for <qemu-devel@nongnu.org>; Mon, 16 Feb 2009 10:46:57 -0500
Received: from squirrel.codemonkey.ws (sig-9-65-85-240.mts.ibm.com
	[9.65.85.240])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	n1GFkunY003026
	for <qemu-devel@nongnu.org>; Mon, 16 Feb 2009 10:46:57 -0500
Message-ID: <49998A9A.8020704@us.ibm.com>
Date: Mon, 16 Feb 2009 09:47:38 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] virtio: Remove malloc failure checks
References: <498FFDA7.1030203@siemens.com>
In-Reply-To: <498FFDA7.1030203@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jan Kiszka wrote:
> No need to check for failing qemu_malloc anymore.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Acked-by: Mark McLoughlin <markmc@redhat.com>
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>
>  hw/virtio-net.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/hw/virtio-net.c b/hw/virtio-net.c
> index 62153e9..b56c10f 100644
> --- a/hw/virtio-net.c
> +++ b/hw/virtio-net.c
> @@ -598,12 +598,8 @@ void virtio_net_init(PCIBus *bus, NICInfo *nd, int devfn)
>      n->promisc = 1; /* for compatibility */
>  
>      n->mac_table.macs = qemu_mallocz(MAC_TABLE_ENTRIES * ETH_ALEN);
> -    if (!n->mac_table.macs)
> -        return;
>  
>      n->vlans = qemu_mallocz(MAX_VLAN >> 3);
> -    if (!n->vlans)
> -        return;
>  
>      register_savevm("virtio-net", virtio_net_id++, VIRTIO_NET_VM_VERSION,
>                      virtio_net_save, virtio_net_load, n);
>
>
>
>