qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Brian Kress <kressb@moose.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] VMware SVGA uses incorrect depth
Date: Mon, 16 Feb 2009 16:27:04 -0500	[thread overview]
Message-ID: <4999DA28.3040404@moose.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

The VMware SVGA adapter is set to a 24 bit depth, where as the display 
surfaces
(and just about everything else) are using a 32 bit depth.  So when you 
use "-vga vmware"
in either the sdl or vnc displays, you get some very odd video that has 
the wrong colors, is
repeated and is only over 3/4 of the screen.  Fix seems to be to change 
it to 32 bit.  With
this patch I can use VMware video in both sdl and vnc and have it 
display correctly.









[-- Attachment #2: patch.vmware_vga --]
[-- Type: text/plain, Size: 426 bytes --]

Signed-off-by: Brian Kress <kressb@moose.net>

Index: hw/vmware_vga.c
===================================================================
--- hw/vmware_vga.c	(revision 6626)
+++ hw/vmware_vga.c	(working copy)
@@ -914,7 +914,7 @@
     s->width = -1;
     s->height = -1;
     s->svgaid = SVGA_ID;
-    s->depth = 24;
+    s->depth = 32;
     s->bypp = (s->depth + 7) >> 3;
     s->cursor.on = 0;
     s->redraw_fifo_first = 0;

             reply	other threads:[~2009-02-16 21:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-16 21:27 Brian Kress [this message]
2009-02-19 21:55 ` [Qemu-devel] Re: [PATCH] VMware SVGA uses incorrect depth Consul
2009-02-27 19:45 ` [Qemu-devel] " Anthony Liguori
2009-02-27 20:21   ` andrzej zaborowski
2009-03-02 11:36     ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4999DA28.3040404@moose.net \
    --to=kressb@moose.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).