From: David Hildenbrand <david@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Peter Xu" <peterx@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v3] memory: Have 'info mtree' remove duplicated Address Space information
Date: Mon, 23 Aug 2021 11:35:57 +0200 [thread overview]
Message-ID: <499a2d67-9234-30ec-2645-4e0f77dc336b@redhat.com> (raw)
In-Reply-To: <CAFEAcA8ok3RL41upiYt3mUeuFc8Nr_HPsQ7h4HvEPM9VH3jmiw@mail.gmail.com>
On 23.08.21 11:28, Peter Maydell wrote:
> On Mon, 23 Aug 2021 at 10:20, David Hildenbrand <david@redhat.com> wrote:
>>
>> On 23.08.21 10:54, Philippe Mathieu-Daudé wrote:
>>> +static void mtree_print_as(gpointer key, gpointer value, gpointer user_data)
>>> +{
>>> + MemoryRegion *mr = key;
>>> + GSList *as_same_root_mr_list = value;
>>> + struct AddressSpaceInfo *asi = user_data;
>>
>> Reverse Christmas tree?
>
> This has never been part of the QEMU style guidelines
> and I would oppose our adding it. It would gain us very little,
> the codebase doesn't consistently follow that rule today so
> it wouldn't be preserving an existing consistency of style,
> and it would be yet another weird stylistic issue that trips
> people up and requires patch repins.
Ah right, it used very inconsistently in the QEMU codebase and even in
this file (I spotted it's the case in the entry of mtree_info() and
wondered if it's the case for this file -- turns out it's absolutely not).
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-08-23 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 8:54 [PATCH v3] memory: Have 'info mtree' remove duplicated Address Space information Philippe Mathieu-Daudé
2021-08-23 9:20 ` David Hildenbrand
2021-08-23 9:28 ` Peter Maydell
2021-08-23 9:35 ` David Hildenbrand [this message]
2021-08-23 10:11 ` Philippe Mathieu-Daudé
2021-09-01 16:01 ` Philippe Mathieu-Daudé
2021-09-01 16:13 ` Philippe Mathieu-Daudé
2021-08-31 20:27 ` Peter Maydell
2021-08-31 22:08 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499a2d67-9234-30ec-2645-4e0f77dc336b@redhat.com \
--to=david@redhat.com \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).