From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LbBRy-0003Sb-2H for qemu-devel@nongnu.org; Sun, 22 Feb 2009 05:20:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LbBRx-0003SC-1h for qemu-devel@nongnu.org; Sun, 22 Feb 2009 05:20:41 -0500 Received: from [199.232.76.173] (port=33293 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LbBRw-0003S9-O1 for qemu-devel@nongnu.org; Sun, 22 Feb 2009 05:20:40 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:55370) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LbBRw-0003ew-5I for qemu-devel@nongnu.org; Sun, 22 Feb 2009 05:20:40 -0500 Message-ID: <49A126F1.6030609@web.de> Date: Sun, 22 Feb 2009 11:20:33 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 0/7] clean build - eliminate warnings References: <20090221190054.12485.30486.stgit@mchn012c.ww002.siemens.net> <761ea48b0902211143x3f791ca8k5e6d0709076ce009@mail.gmail.com> <49A05F5D.6070903@web.de> <20090222005904.GA16651@edgar.se.axis.com> In-Reply-To: <20090222005904.GA16651@edgar.se.axis.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2075166E6DDDF7282AB493A2" Sender: jan.kiszka@web.de Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2075166E6DDDF7282AB493A2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Edgar E. Iglesias wrote: > On Sat, Feb 21, 2009 at 09:09:01PM +0100, Jan Kiszka wrote: >> Laurent Desnogues wrote: >>> On Sat, Feb 21, 2009 at 8:00 PM, Jan Kiszka wrote= : >>>> When working on larger or intrusive changes like the monitor rework,= the >>>> number of warnings a normal build generates (here: x86-64 host, gcc = 4.3) >>>> is still too high. And sometimes these warnings are not just of cosm= etic >>>> nature, see (reposted) patch 3. >>>> >>>> This series reduces the number of warnings significantly, still not = to >>>> zero (someone would have to look into the NetWinder stuff), but almo= st: >>>> >>>> Warning summary for 2009-02-21 (changes since 2009-02-21-base) >>>> generic 0 (-1) >>>> softmmu 0 (-39) >>>> x86 0 (0) >>>> arm 0 (-10) >>> This means that after applying your patch there should be no more >>> warning for the ARM target? >> At least for softmmu, at least with my compiler (depending on the >> precise version / distro patches, you may have different warnings >> enabled by default): yes. >> >>> On my machine (x86_64, gcc 4.1.2), I still get these: >>> >>> CC arm-softmmu/neon_helper.o >>> /home/ldesnogu/work/Emu/qemu/svn-ref/target-arm/neon_helper.c: In >>> function ?helper_neon_rshl_s8?: >>> /home/ldesnogu/work/Emu/qemu/svn-ref/target-arm/neon_helper.c:469: >>> warning: ?vdest.v1? is used uninitialized in this function >>> /home/ldesnogu/work/Emu/qemu/svn-ref/target-arm/neon_helper.c:469: >>> warning: ?vdest.v2? is used uninitialized in this function >>> /home/ldesnogu/work/Emu/qemu/svn-ref/target-arm/neon_helper.c:469: >>> warning: ?vdest.v3? is used uninitialized in this function >>> /home/ldesnogu/work/Emu/qemu/svn-ref/target-arm/neon_helper.c:469: >>> warning: ?vdest.v4? is used uninitialized in this function >>> /home/ldesnogu/work/Emu/qemu/svn-ref/target-arm/neon_helper.c: In >>> function ?helper_neon_rshl_s16?: >>> /home/ldesnogu/work/Emu/qemu/svn-ref/target-arm/neon_helper.c:470: >>> warning: ?vdest.v1? is used uninitialized in this function >>> /home/ldesnogu/work/Emu/qemu/svn-ref/target-arm/neon_helper.c:470: >>> warning: ?vdest.v2? is used uninitialized in this function >>> /home/ldesnogu/work/Emu/qemu/svn-ref/target-arm/neon_helper.c: In >>> function ?helper_neon_rshl_s32?: >>> /home/ldesnogu/work/Emu/qemu/svn-ref/target-arm/neon_helper.c:471: >>> warning: ?vdest.v1? is used uninitialized in this function >> Has this been identified as a real issue or just compiler blindness (m= y >> series contains one "fix" for such blindness, see cris patch)? I'm >=20 > Sorry, I missed any posted CRIS patch. Please post it again if you > have one and please CC me and I'll apply it if I agree with it. >=20 > Sorry if I missed your email. There is nothing you missed, I was referring to patch 5 of this series. I'll sent out a fixed version soon and put you on CC this time. The point is that I lost a bit interest in building up proper CC lists here due to the (IMHO) broken list configuration of inserting reply-to headers. That way CCs typically get lost when someone picks up a thread from the list. Unfortunately, no one replied on my RFC [1] to fix this (because I forgot the proper CCs? :->). Jan [1] http://permalink.gmane.org/gmane.comp.emulators.qemu/28472 --------------enig2075166E6DDDF7282AB493A2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkmhJvYACgkQniDOoMHTA+mu3QCfRvUPm7m/CmyO/DZEWBqeoy67 ODcAnjGJT4URLe5tbQAlZ0QwKL+G6OUu =J3vj -----END PGP SIGNATURE----- --------------enig2075166E6DDDF7282AB493A2--