From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LbcbX-0005gD-97 for qemu-devel@nongnu.org; Mon, 23 Feb 2009 10:20:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LbcbT-0005eb-9b for qemu-devel@nongnu.org; Mon, 23 Feb 2009 10:20:22 -0500 Received: from [199.232.76.173] (port=38320 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LbcbT-0005eU-5X for qemu-devel@nongnu.org; Mon, 23 Feb 2009 10:20:19 -0500 Received: from qw-out-1920.google.com ([74.125.92.146]:49997) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LbcbS-0002vC-QP for qemu-devel@nongnu.org; Mon, 23 Feb 2009 10:20:19 -0500 Received: by qw-out-1920.google.com with SMTP id 4so592059qwk.4 for ; Mon, 23 Feb 2009 07:20:18 -0800 (PST) Message-ID: <49A2BE93.10000@codemonkey.ws> Date: Mon, 23 Feb 2009 09:19:47 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [6631] Avoid infinite loop around timed condition variable References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------020806020708050303020208" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------020806020708050303020208 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit C.W. Betts wrote: > Will these patches help with the OS X hang? Can you try the attached patch? I never got any feedback about whether it fixed the problem. Regards, Anthony Liguori > On Feb 20, 2009, at 10:48 PM, malc wrote >> > --------------020806020708050303020208 Content-Type: application/mbox; name="posix-aio-pipe.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="posix-aio-pipe.patch" U3ViamVjdDogW1BBVENIXSBEbyBub3QgdXNlIHNpZ25hbHMgaW4gcG9zaXgtYWlvCgpUaGUg c2lnbmFsLXNlbGVjdCByYWNlIGZvcmNlcyB1cyB0byB1c2UgYSBmaWxlIGRlc2NyaXB0b3Ig Zm9yIHBvc2l4LWFpbwpub3RpZmljYXRpb24uICBDdXJyZW50bHksIHdlIHVzZSBhIHBpcGUg YW5kIHdyaXRlIHRvIGl0IGZyb20gdGhlIHNpZ25hbCBoYW5kbGVyCmJlY2F1c2Ugbm9ybWFs IHBvc2l4LWFpbyBkb2VzIG5vdCBwcm92aWRlIGZpbGUgZGVzY3JpcHRvciBub3RpZmljYXRp b24gc3VwcG9ydC4KClNpbmNlIHdlIG5vdyBlbXVsYXRpb24gcG9zaXgtYWlvIG9uIG91ciBv d24sIHdlIGNhbiBjbGVhbiB0aGluZ3MgdXAgYW5kIGp1c3QKdXNlIGEgZmlsZSBkZXNjcmlw dG9yIGZvciBub3RpZmljYXRpb24uCgpOLkIuIFRoaXMgaXMgYWxtb3N0IGNlcnRhaW5seSBn b2luZyB0byBjYXVzZSByZWdyZXNzaW9ucyB1bnRpbCB3ZSBmaXggdGhlCnNlbGVjdCBsb29w IHRvIHJ1biBpbiBhIHNlcGFyYXRlIHRocmVhZCBzaW5jZSB0aGVyZSB3aWxsIG5vIGxvbmdl ciBiZSBhIHNpZ25hbAp0aGF0IGJyZWFrcyB1cyBvdXQgb2YgdGhlIFRDRyBydW4gbG9vcC4g IFdlIG5lZWQgdG8gaG9sZCBvZmYgb24gYXBwbHlpbmcgdGhpcwpwYXRjaCB1bnRpbCB0aGF0 IGlzIGZpeGVkIHByb3Blcmx5LgoKU2lnbmVkLW9mZi1ieTogQW50aG9ueSBMaWd1b3JpIDxh bGlndW9yaUB1cy5pYm0uY29tPgoKZGlmZiAtLWdpdCBhL2Jsb2NrLXJhdy1wb3NpeC5jIGIv YmxvY2stcmF3LXBvc2l4LmMKaW5kZXggNDQwNGViMS4uY2FlNDQwOCAxMDA2NDQKLS0tIGEv YmxvY2stcmF3LXBvc2l4LmMKKysrIGIvYmxvY2stcmF3LXBvc2l4LmMKQEAgLTUxMSwyMCAr NTExLDExIEBAIHN0YXRpYyBpbnQgcG9zaXhfYWlvX2ZsdXNoKHZvaWQgKm9wYXF1ZSkKIAog c3RhdGljIFBvc2l4QWlvU3RhdGUgKnBvc2l4X2Fpb19zdGF0ZTsKIAotc3RhdGljIHZvaWQg YWlvX3NpZ25hbF9oYW5kbGVyKGludCBzaWdudW0pCi17Ci0gICAgaWYgKHBvc2l4X2Fpb19z dGF0ZSkgewotICAgICAgICBjaGFyIGJ5dGUgPSAwOwotCi0gICAgICAgIHdyaXRlKHBvc2l4 X2Fpb19zdGF0ZS0+d2ZkLCAmYnl0ZSwgc2l6ZW9mKGJ5dGUpKTsKLSAgICB9Ci0KLSAgICBx ZW11X3NlcnZpY2VfaW8oKTsKLX0KKy8qIEZJWE1FIG5lZWQgdG8gZml4IHRoZSBzZWxlY3Qo KSBsb29wIGlzc3VlIGIvYyB0aGlzIElPIHdpbGwgbm90CisgKiBuZWNlc3NhcmlseSBicmVh ayBvdXQgdXMgb3V0IHRoZSBUQ0cgbG9vcCAqLwogCiBzdGF0aWMgaW50IHBvc2l4X2Fpb19p bml0KHZvaWQpCiB7Ci0gICAgc3RydWN0IHNpZ2FjdGlvbiBhY3Q7CiAgICAgUG9zaXhBaW9T dGF0ZSAqczsKICAgICBpbnQgZmRzWzJdOwogICAgIHN0cnVjdCBxZW11X3BhaW9pbml0IGFp OwpAQCAtNTM2LDExICs1MjcsNiBAQCBzdGF0aWMgaW50IHBvc2l4X2Fpb19pbml0KHZvaWQp CiAgICAgaWYgKHMgPT0gTlVMTCkKICAgICAgICAgcmV0dXJuIC1FTk9NRU07CiAKLSAgICBz aWdmaWxsc2V0KCZhY3Quc2FfbWFzayk7Ci0gICAgYWN0LnNhX2ZsYWdzID0gMDsgLyogZG8g bm90IHJlc3RhcnQgc3lzY2FsbHMgdG8gaW50ZXJydXB0IHNlbGVjdCgpICovCi0gICAgYWN0 LnNhX2hhbmRsZXIgPSBhaW9fc2lnbmFsX2hhbmRsZXI7Ci0gICAgc2lnYWN0aW9uKFNJR1VT UjIsICZhY3QsIE5VTEwpOwotCiAgICAgcy0+Zmlyc3RfYWlvID0gTlVMTDsKICAgICBpZiAo cGlwZShmZHMpID09IC0xKSB7CiAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiZmFpbGVkIHRv IGNyZWF0ZSBwaXBlXG4iKTsKQEAgLTU3OSw3ICs1NjUsNyBAQCBzdGF0aWMgUmF3QUlPQ0Ig KnJhd19haW9fc2V0dXAoQmxvY2tEcml2ZXJTdGF0ZSAqYnMsCiAgICAgaWYgKCFhY2IpCiAg ICAgICAgIHJldHVybiBOVUxMOwogICAgIGFjYi0+YWlvY2IuYWlvX2ZpbGRlcyA9IHMtPmZk OwotICAgIGFjYi0+YWlvY2IuZXZfc2lnbm8gPSBTSUdVU1IyOworICAgIGFjYi0+YWlvY2Iu ZXZfZmQgPSBwb3NpeF9haW9fc3RhdGUtPndmZDsKICAgICBhY2ItPmFpb2NiLmFpb19idWYg PSBidWY7CiAgICAgaWYgKG5iX3NlY3RvcnMgPCAwKQogICAgICAgICBhY2ItPmFpb2NiLmFp b19uYnl0ZXMgPSAtbmJfc2VjdG9yczsKZGlmZiAtLWdpdCBhL3Bvc2l4LWFpby1jb21wYXQu YyBiL3Bvc2l4LWFpby1jb21wYXQuYwppbmRleCBmMTQxY2Q5Li40NDA5ODk5IDEwMDY0NAot LS0gYS9wb3NpeC1haW8tY29tcGF0LmMKKysrIGIvcG9zaXgtYWlvLWNvbXBhdC5jCkBAIC0y Nyw2ICsyNywxNSBAQCBzdGF0aWMgaW50IGN1cl90aHJlYWRzID0gMDsKIHN0YXRpYyBpbnQg aWRsZV90aHJlYWRzID0gMDsKIHN0YXRpYyBUQUlMUV9IRUFEKCwgcWVtdV9wYWlvY2IpIHJl cXVlc3RfbGlzdDsKIAorc3RhdGljIHZvaWQgc2lnbmFsX2ZkKGludCBmZCkKK3sKKyAgICBz c2l6ZV90IGxlbjsKKyAgICBkbyB7CisgICAgICAgIGNoYXIgdmFsdWUgPSAxOworICAgICAg ICBsZW4gPSB3cml0ZShmZCwgJnZhbHVlLCAxKTsKKyAgICB9IHdoaWxlIChsZW4gPT0gLTEg JiYgZXJybm8gPT0gRUlOVFIpOworfQorCiBzdGF0aWMgdm9pZCAqYWlvX3RocmVhZCh2b2lk ICp1bnVzZWQpCiB7CiAgICAgc2lnc2V0X3Qgc2V0OwpAQCAtOTIsOSArMTAxLDggQEAgc3Rh dGljIHZvaWQgKmFpb190aHJlYWQodm9pZCAqdW51c2VkKQogICAgICAgICBwdGhyZWFkX211 dGV4X2xvY2soJmxvY2spOwogICAgICAgICBhaW9jYi0+cmV0ID0gb2Zmc2V0OwogICAgICAg ICBpZGxlX3RocmVhZHMrKzsKKyAgICAgICAgc2lnbmFsX2ZkKGFpb2NiLT5ldl9mZCk7CiAg ICAgICAgIHB0aHJlYWRfbXV0ZXhfdW5sb2NrKCZsb2NrKTsKLQotICAgICAgICBraWxsKGdl dHBpZCgpLCBhaW9jYi0+ZXZfc2lnbm8pOwogICAgIH0KIAogICAgIGlkbGVfdGhyZWFkcy0t OwpkaWZmIC0tZ2l0IGEvcG9zaXgtYWlvLWNvbXBhdC5oIGIvcG9zaXgtYWlvLWNvbXBhdC5o CmluZGV4IDBiYzEwZjUuLmVjMTdiYjYgMTAwNjQ0Ci0tLSBhL3Bvc2l4LWFpby1jb21wYXQu aAorKysgYi9wb3NpeC1haW8tY29tcGF0LmgKQEAgLTI5LDcgKzI5LDcgQEAgc3RydWN0IHFl bXVfcGFpb2NiCiAgICAgaW50IGFpb19maWxkZXM7CiAgICAgdm9pZCAqYWlvX2J1ZjsKICAg ICBzaXplX3QgYWlvX25ieXRlczsKLSAgICBpbnQgZXZfc2lnbm87CisgICAgaW50IGV2X2Zk OwogICAgIG9mZl90IGFpb19vZmZzZXQ7CiAKICAgICAvKiBwcml2YXRlICovCg== --------------020806020708050303020208--