From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LbduE-0000xI-Jo
	for qemu-devel@nongnu.org; Mon, 23 Feb 2009 11:43:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LbduE-0000wv-4d
	for qemu-devel@nongnu.org; Mon, 23 Feb 2009 11:43:46 -0500
Received: from [199.232.76.173] (port=36595 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LbduD-0000wp-R3
	for qemu-devel@nongnu.org; Mon, 23 Feb 2009 11:43:45 -0500
Received: from pop-gadwall.atl.sa.earthlink.net ([207.69.195.61]:45728)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <reif@earthlink.net>) id 1LbduD-0006Oo-CI
	for qemu-devel@nongnu.org; Mon, 23 Feb 2009 11:43:45 -0500
Received: from user-142h2k8.cable.mindspring.com ([72.40.138.136]
	helo=[192.168.0.90])
	by pop-gadwall.atl.sa.earthlink.net with esmtp (Exim 3.36 #1)
	id 1LbduC-0002OG-00
	for qemu-devel@nongnu.org; Mon, 23 Feb 2009 11:43:44 -0500
Message-ID: <49A2D23F.4020007@earthlink.net>
Date: Mon, 23 Feb 2009 11:43:43 -0500
From: Robert Reif <reif@earthlink.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [5849] Change MMIO callbacks to use offsets,	not
	absolute addresses.
References: <E1L7Dzr-0004Qe-Bx@cvs.savannah.gnu.org>	<200902231236.26691.paul@nowt.org>
	<49A299CF.3010602@earthlink.net> <200902231316.15214.paul@nowt.org>
In-Reply-To: <200902231316.15214.paul@nowt.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Paul Brook wrote:
> Should be fixed now.
>
>   
Not really.  This fixes that specific case but it doesn't fix the 
general case where a hardware device needs to call do_unassigned_access 
because the hardware device still only has the offset. 

You could store the physical base in each hardware device and recreate 
the physical address but that requires changing all hardware devices 
that need to do that.  Why should the hardware drivers go through the 
trouble to recreate a physical address when just a few instructions 
before then the physical address was known but irreversibly destroyed 
when it was converted to an offset.