[Qemu-devel] downscript not run when using quit in monitor

[Qemu-devel] downscript not run when using quit in monitor

[Jędrzej Kalinowski]

Hello,

I'm using qemu to simulate various network booting scenarios w pxe/gPXE.
I use my ifup / ifdown script to set up / destroy tap devices form the qemu
instance. 

However if I 'quit' qemu from the monitor - the downscript is not executed.
Is it by design or should it be classified as a bug? 
If it's fine - how can I close the machine properly (with downscript
execution) in -curses mode? It has no OS loaded - it didn't succeded to
boot from pxe..

Thanks,
Jedrzej Kalinowski
-- 
JK

Re: [Qemu-devel] downscript not run when using quit in monitor

[Jędrzej Kalinowski]

On Thu, 19 Feb 2009 11:27:19 +0100, Jędrzej Kalinowski
<kalinoj1@iem.pw.edu.pl> wrote:
> Hello,
> 
> I'm using qemu to simulate various network booting scenarios w pxe/gPXE.
> I use my ifup / ifdown script to set up / destroy tap devices form the
qemu
> instance. 
> 
> However if I 'quit' qemu from the monitor - the downscript is not
executed.
> Is it by design or should it be classified as a bug? 
> If it's fine - how can I close the machine properly (with downscript
> execution) in -curses mode? It has no OS loaded - it didn't succeded to
> boot from pxe..
> 

Following is a trivial patch I needed to apply to make downscripts
execute...
Maybe will save a few seconds to someone..

Cheers - Jędrzej

--- monitor.c.orig      2009-02-22 19:13:22.000000000 +0100
+++ monitor.c   2009-02-22 18:53:17.000000000 +0100
@@ -380,6 +380,7 @@
 
 static void do_quit(void)
 {
+    net_cleanup();
     exit(0);
 }
 

[Qemu-devel] Re: downscript not run when using quit in monitor

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

Jędrzej Kalinowski wrote:
> On Thu, 19 Feb 2009 11:27:19 +0100, Jędrzej Kalinowski
> <kalinoj1@iem.pw.edu.pl> wrote:
>> Hello,
>>
>> I'm using qemu to simulate various network booting scenarios w pxe/gPXE.
>> I use my ifup / ifdown script to set up / destroy tap devices form the
> qemu
>> instance. 
>>
>> However if I 'quit' qemu from the monitor - the downscript is not
> executed.
>> Is it by design or should it be classified as a bug? 
>> If it's fine - how can I close the machine properly (with downscript
>> execution) in -curses mode? It has no OS loaded - it didn't succeded to
>> boot from pxe..
>>
> 
> Following is a trivial patch I needed to apply to make downscripts
> execute...
> Maybe will save a few seconds to someone..
> 
> Cheers - Jędrzej
> 
> --- monitor.c.orig      2009-02-22 19:13:22.000000000 +0100
> +++ monitor.c   2009-02-22 18:53:17.000000000 +0100
> @@ -380,6 +380,7 @@
>  
>  static void do_quit(void)
>  {
> +    net_cleanup();
>      exit(0);
>  }
>  

Generally, this looks reasonable to me. But to catch also other exits,
you probably want to install an atexit handler. And please post your
patches with signed-off and an easily extractable commit comment.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]