From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lc6yv-0005KC-Qf for qemu-devel@nongnu.org; Tue, 24 Feb 2009 18:46:33 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lc6yt-0005K0-Ri for qemu-devel@nongnu.org; Tue, 24 Feb 2009 18:46:32 -0500 Received: from [199.232.76.173] (port=48143 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lc6yt-0005Jx-LY for qemu-devel@nongnu.org; Tue, 24 Feb 2009 18:46:31 -0500 Received: from pop-sarus.atl.sa.earthlink.net ([207.69.195.72]:49514) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lc6yt-0005E6-Ds for qemu-devel@nongnu.org; Tue, 24 Feb 2009 18:46:31 -0500 Message-ID: <49A486D1.3000305@earthlink.net> Date: Tue, 24 Feb 2009 18:46:25 -0500 From: Robert Reif MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC] 64 bit device I/O References: <49A01839.3090402@earthlink.net> <49A3ECF9.1050507@earthlink.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl Blue Swirl wrote: > Would it be better to use a structure with four elements with correct > types (including uint8/16_t) instead of the cast? This could also be > limited to only cpu_register_io_memory64. > > > This is what I would prefer and is what the first version of this patch that I submitted a year ago did: http://landley.net/qemu/2008-01-01.html The problem is that every hardware driver would need to be changed and some of them would need to be changed drastically because they use the same functions for all three data sizes. No one seemed interested in this approach so I abandoned it. This approach while uglier requires no changes to the hardware drivers unless they need 64 bit support so I hoped it would be better received.