From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lciii-00088G-9q
	for qemu-devel@nongnu.org; Thu, 26 Feb 2009 11:04:20 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lciig-00087x-Kx
	for qemu-devel@nongnu.org; Thu, 26 Feb 2009 11:04:19 -0500
Received: from [199.232.76.173] (port=43769 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lciig-00087u-FK
	for qemu-devel@nongnu.org; Thu, 26 Feb 2009 11:04:18 -0500
Received: from e4.ny.us.ibm.com ([32.97.182.144]:42554)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1Lciif-00066v-UB
	for qemu-devel@nongnu.org; Thu, 26 Feb 2009 11:04:18 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n1QG1qOW010825
	for <qemu-devel@nongnu.org>; Thu, 26 Feb 2009 11:01:52 -0500
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n1QG4Erh195360
	for <qemu-devel@nongnu.org>; Thu, 26 Feb 2009 11:04:15 -0500
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n1QG4Eul030831
	for <qemu-devel@nongnu.org>; Thu, 26 Feb 2009 11:04:14 -0500
Message-ID: <49A6BD7D.6040505@us.ibm.com>
Date: Thu, 26 Feb 2009 10:04:13 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <20090218172920.GH15606@random.random>
In-Reply-To: <20090218172920.GH15606@random.random>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] ide_dma_cancel will result in partial DMA
 transfer (resend #3)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: qemu-devel@nongnu.org

Andrea Arcangeli wrote:
> +	if (bm->aiocb) {
> +		QEMU_WARN("qemu_aio_flush called");
>   

This doesn't build (there is no QEMU_WARN).  I think I've mentioned this 
before?

Regards,

Anthony Liguori

> +		qemu_aio_flush();
> +		if (bm->aiocb)
> +			QEMU_WARN("aiocb still pending");
> +		if (bm->status & BM_STATUS_DMAING)
> +			QEMU_WARN("BM_STATUS_DMAING still pending");
> +	}
>          bm->cmd = val & 0x09;
>      } else {
>          if (!(bm->status & BM_STATUS_DMAING)) {
>
>