From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fix raw_aio_remove
Date: Thu, 26 Feb 2009 10:40:39 -0600 [thread overview]
Message-ID: <49A6C607.9090002@us.ibm.com> (raw)
In-Reply-To: <499C3D4D.9060108@eu.citrix.com>
Stefano Stabellini wrote:
> Hi all,
> this small patch fixes a bug in the list iteration of raw_aio_remove.
> Cheers,
>
Applied. Thanks.
Regards,
Anthony Liguori
> Stefano
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>
> diff --git a/block-raw-posix.c b/block-raw-posix.c
> index 620791b..85ca704 100644
> --- a/block-raw-posix.c
> +++ b/block-raw-posix.c
> @@ -604,13 +604,14 @@ static void raw_aio_remove(RawAIOCB *acb)
> pacb = &posix_aio_state->first_aio;
> for(;;) {
> if (*pacb == NULL) {
> + fprintf(stderr, "raw_aio_remove: aio request not found!\n");
> break;
> } else if (*pacb == acb) {
> *pacb = acb->next;
> qemu_aio_release(acb);
> break;
> }
> - pacb = &acb->next;
> + pacb = &(*pacb)->next;
> }
> }
>
>
>
>
>
prev parent reply other threads:[~2009-02-26 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 16:54 [Qemu-devel] [PATCH] fix raw_aio_remove Stefano Stabellini
2009-02-26 16:40 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A6C607.9090002@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).