* [Qemu-devel] [PATCH] fix raw_aio_remove
@ 2009-02-18 16:54 Stefano Stabellini
2009-02-26 16:40 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Stabellini @ 2009-02-18 16:54 UTC (permalink / raw)
To: qemu-devel@nongnu.org
Hi all,
this small patch fixes a bug in the list iteration of raw_aio_remove.
Cheers,
Stefano
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
diff --git a/block-raw-posix.c b/block-raw-posix.c
index 620791b..85ca704 100644
--- a/block-raw-posix.c
+++ b/block-raw-posix.c
@@ -604,13 +604,14 @@ static void raw_aio_remove(RawAIOCB *acb)
pacb = &posix_aio_state->first_aio;
for(;;) {
if (*pacb == NULL) {
+ fprintf(stderr, "raw_aio_remove: aio request not found!\n");
break;
} else if (*pacb == acb) {
*pacb = acb->next;
qemu_aio_release(acb);
break;
}
- pacb = &acb->next;
+ pacb = &(*pacb)->next;
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] fix raw_aio_remove
2009-02-18 16:54 [Qemu-devel] [PATCH] fix raw_aio_remove Stefano Stabellini
@ 2009-02-26 16:40 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2009-02-26 16:40 UTC (permalink / raw)
To: qemu-devel
Stefano Stabellini wrote:
> Hi all,
> this small patch fixes a bug in the list iteration of raw_aio_remove.
> Cheers,
>
Applied. Thanks.
Regards,
Anthony Liguori
> Stefano
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>
> diff --git a/block-raw-posix.c b/block-raw-posix.c
> index 620791b..85ca704 100644
> --- a/block-raw-posix.c
> +++ b/block-raw-posix.c
> @@ -604,13 +604,14 @@ static void raw_aio_remove(RawAIOCB *acb)
> pacb = &posix_aio_state->first_aio;
> for(;;) {
> if (*pacb == NULL) {
> + fprintf(stderr, "raw_aio_remove: aio request not found!\n");
> break;
> } else if (*pacb == acb) {
> *pacb = acb->next;
> qemu_aio_release(acb);
> break;
> }
> - pacb = &acb->next;
> + pacb = &(*pacb)->next;
> }
> }
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-26 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-18 16:54 [Qemu-devel] [PATCH] fix raw_aio_remove Stefano Stabellini
2009-02-26 16:40 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).