* [Qemu-devel] [PATCH] Fix qemu-img argument handling
@ 2009-02-07 16:29 Hervé Poussineau
2009-02-07 20:11 ` Robert Riebisch
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Hervé Poussineau @ 2009-02-07 16:29 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
Hi,
qemu-img doesn't work on MS Windows, when compiled with MinGW Runtime
package >= 3.15
According to
http://sourceforge.net/tracker/index.php?func=detail&aid=2222263&group_id=2435&atid=102435
, qemu-img shouldn't skip the first argument (command name) by doing
optind++.
Attached patch fixes the problems, and repairs qemu-img parsing with
MinGW Runtime package >= 3.15
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Hervé
[-- Attachment #2: qemu-img-optind.diff --]
[-- Type: plain/text, Size: 379 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] Fix qemu-img argument handling
2009-02-07 16:29 [Qemu-devel] [PATCH] Fix qemu-img argument handling Hervé Poussineau
@ 2009-02-07 20:11 ` Robert Riebisch
2009-02-09 18:15 ` Aurelien Jarno
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Robert Riebisch @ 2009-02-07 20:11 UTC (permalink / raw)
To: qemu-devel
Hervé Poussineau wrote:
> According to
> http://sourceforge.net/tracker/index.php?func=detail&aid=2222263&group_id=2435&atid=102435
> , qemu-img shouldn't skip the first argument (command name) by doing
> optind++.
Oh, that was me in November. ;-)
> Attached patch fixes the problems, and repairs qemu-img parsing with
> MinGW Runtime package >= 3.15
Thanks for this patch! :-)
Robert Riebisch
--
BTTR Software
http://www.bttr-software.de/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] Fix qemu-img argument handling
2009-02-07 16:29 [Qemu-devel] [PATCH] Fix qemu-img argument handling Hervé Poussineau
2009-02-07 20:11 ` Robert Riebisch
@ 2009-02-09 18:15 ` Aurelien Jarno
2009-02-14 17:33 ` Robert Riebisch
2009-02-27 19:08 ` Anthony Liguori
3 siblings, 0 replies; 5+ messages in thread
From: Aurelien Jarno @ 2009-02-09 18:15 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-devel
On Sat, Feb 07, 2009 at 05:29:11PM +0100, Hervé Poussineau wrote:
> Hi,
>
> qemu-img doesn't work on MS Windows, when compiled with MinGW Runtime
> package >= 3.15
> According to
> http://sourceforge.net/tracker/index.php?func=detail&aid=2222263&group_id=2435&atid=102435
> , qemu-img shouldn't skip the first argument (command name) by doing
> optind++.
>
> Attached patch fixes the problems, and repairs qemu-img parsing with
> MinGW Runtime package >= 3.15
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix qemu-img argument handling
2009-02-07 16:29 [Qemu-devel] [PATCH] Fix qemu-img argument handling Hervé Poussineau
2009-02-07 20:11 ` Robert Riebisch
2009-02-09 18:15 ` Aurelien Jarno
@ 2009-02-14 17:33 ` Robert Riebisch
2009-02-27 19:08 ` Anthony Liguori
3 siblings, 0 replies; 5+ messages in thread
From: Robert Riebisch @ 2009-02-14 17:33 UTC (permalink / raw)
To: qemu-devel
Hervé Poussineau wrote:
> qemu-img doesn't work on MS Windows, when compiled with MinGW Runtime
> package >= 3.15
Keith Marshall of MinGW submitted a patch to getopt() behaviour:
https://sourceforge.net/tracker/?func=detail&atid=352435&aid=2222263&group_id=2435
Robert Riebisch
--
BTTR Software
http://www.bttr-software.de/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix qemu-img argument handling
2009-02-07 16:29 [Qemu-devel] [PATCH] Fix qemu-img argument handling Hervé Poussineau
` (2 preceding siblings ...)
2009-02-14 17:33 ` Robert Riebisch
@ 2009-02-27 19:08 ` Anthony Liguori
3 siblings, 0 replies; 5+ messages in thread
From: Anthony Liguori @ 2009-02-27 19:08 UTC (permalink / raw)
To: qemu-devel
Hervé Poussineau wrote:
> Hi,
>
> qemu-img doesn't work on MS Windows, when compiled with MinGW Runtime
> package >= 3.15
> According to
> http://sourceforge.net/tracker/index.php?func=detail&aid=2222263&group_id=2435&atid=102435
> , qemu-img shouldn't skip the first argument (command name) by doing
> optind++.
>
> Attached patch fixes the problems, and repairs qemu-img parsing with
> MinGW Runtime package >= 3.15
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
This resend either inlining the patch or attaching it with text/plan.
Regards,
Anthony Liguori
> Hervé
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-02-27 19:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-07 16:29 [Qemu-devel] [PATCH] Fix qemu-img argument handling Hervé Poussineau
2009-02-07 20:11 ` Robert Riebisch
2009-02-09 18:15 ` Aurelien Jarno
2009-02-14 17:33 ` Robert Riebisch
2009-02-27 19:08 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).