From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ld8eE-0000Oo-06
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:45:26 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ld8eB-0000LP-5v
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:45:24 -0500
Received: from [199.232.76.173] (port=55129 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ld8eB-0000L9-0V
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:45:23 -0500
Received: from e8.ny.us.ibm.com ([32.97.182.138]:44717)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1Ld8eA-0004cR-Fq
	for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:45:22 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e8.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n1RJc0mj015163
	for <qemu-devel@nongnu.org>; Fri, 27 Feb 2009 14:38:00 -0500
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n1RJjLWI196700
	for <qemu-devel@nongnu.org>; Fri, 27 Feb 2009 14:45:21 -0500
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n1RJjL2B003673
	for <qemu-devel@nongnu.org>; Fri, 27 Feb 2009 14:45:21 -0500
Received: from squirrel.codemonkey.ws (sig-9-65-0-122.mts.ibm.com [9.65.0.122])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	n1RJjJ9F003509
	for <qemu-devel@nongnu.org>; Fri, 27 Feb 2009 14:45:20 -0500
Message-ID: <49A842CD.1000306@us.ibm.com>
Date: Fri, 27 Feb 2009 13:45:17 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] VMware SVGA uses incorrect depth
References: <4999DA28.3040404@moose.net>
In-Reply-To: <4999DA28.3040404@moose.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Brian Kress wrote:
> The VMware SVGA adapter is set to a 24 bit depth, where as the display 
> surfaces
> (and just about everything else) are using a 32 bit depth.  So when 
> you use "-vga vmware"
> in either the sdl or vnc displays, you get some very odd video that 
> has the wrong colors, is
> repeated and is only over 3/4 of the screen.  Fix seems to be to 
> change it to 32 bit.  With
> this patch I can use VMware video in both sdl and vnc and have it 
> display correctly.
>
>
> Signed-off-by: Brian Kress <kressb@moose.net>
>
> Index: hw/vmware_vga.c
> ===================================================================
> --- hw/vmware_vga.c	(revision 6626)
> +++ hw/vmware_vga.c	(working copy)
> @@ -914,7 +914,7 @@
>      s->width = -1;
>      s->height = -1;
>      s->svgaid = SVGA_ID;
> -    s->depth = 24;
> +    s->depth = 32;
>      s->bypp = (s->depth + 7) >> 3;
>   
I think having:

s->depth = 24;
s->bypp = 4;

Is a better fix.   Can you test that?

Regards,

Anthony Liguori
>      s->cursor.on = 0;
>   

     s->redraw_fifo_first = 0;