From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ld8mx-0008SH-4s for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:54:27 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ld8mu-0008Pk-HE for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:54:26 -0500 Received: from [199.232.76.173] (port=40348 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ld8mu-0008PV-9v for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:54:24 -0500 Received: from e4.ny.us.ibm.com ([32.97.182.144]:48910) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ld8mu-0005jZ-3G for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:54:24 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n1RJpurr009026 for ; Fri, 27 Feb 2009 14:51:56 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n1RJsKIO101312 for ; Fri, 27 Feb 2009 14:54:20 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n1RJr512013596 for ; Fri, 27 Feb 2009 14:53:05 -0500 Received: from squirrel.codemonkey.ws (sig-9-65-0-122.mts.ibm.com [9.65.0.122]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n1RJr5et013541 for ; Fri, 27 Feb 2009 14:53:05 -0500 Message-ID: <49A844EA.7000608@us.ibm.com> Date: Fri, 27 Feb 2009 13:54:18 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Missing cirrus_invalidate_region() in cirrus_do_copy() References: <4999E40A.9070304@moose.net> In-Reply-To: <4999E40A.9070304@moose.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Brian Kress wrote: > After doing a video to video copy, cirrus_do_copy() in cirrus_vga.c > does a conditional > call to cirrus_invalidate_region() with an "if (!notify)" test. > However at this point the blt > has already been done so it seems like this call should be made > unconditionally. The patch > below fixes some display update problems when dragging windows under > both X (fedora > 10 guest) and a Windows XP guest. Applied. Thanks. Regards, Anthony Liguori > >