From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ld93x-0002LA-Nx for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:12:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ld93w-0002K1-V0 for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:12:01 -0500 Received: from [199.232.76.173] (port=32916 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ld93w-0002Js-Q8 for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:12:00 -0500 Received: from e35.co.us.ibm.com ([32.97.110.153]:58294) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ld93w-0000qu-EM for qemu-devel@nongnu.org; Fri, 27 Feb 2009 15:12:00 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e35.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n1RK87Ka021885 for ; Fri, 27 Feb 2009 13:08:07 -0700 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n1RKBwIo198348 for ; Fri, 27 Feb 2009 13:11:58 -0700 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n1RKBvKC018554 for ; Fri, 27 Feb 2009 13:11:58 -0700 Message-ID: <49A8490B.3090600@us.ibm.com> Date: Fri, 27 Feb 2009 14:11:55 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH][RFC] Fix SDL on evdev hosts References: <1235756074-1719-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org Blue Swirl wrote: > On 2/27/09, Anthony Liguori wrote: > >> This patch corrects SDL support on X11 hosts using evdev. It's losely based >> on the previous patch by Dustin Kirkland and the evdev support code in gtk-vnc >> written by Daniel Berrange. >> >> I've tried to take into account all past feedback from previous patches posted >> including a proper set of configure checks. I've tested this on win32 but >> I'd like some more eyes to look at it. >> >> Signed-off-by: Anthony Liguori >> > > Just a micro nitpick: > >> +#ifndef _QEMU_X_KEYMAP_H >> +#define _QEMU_X_KEYMAP_H >> + >> +extern uint8_t translate_xfree86_keycode(const int key); >> + >> +extern uint8_t translate_evdev_keycode(const int key); >> + >> +#endif >> + >> > > Looks like an extra newline at the end of file? ;-) > Indeed, and now it's gone :-) Thanks. Regards, Anthony Liguori > The #endif does not have the traditional /* _QEMU_X_KEYMAP_H */ > ending, but I don't care much for those. >