From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LdpcU-0002Vf-Ld
	for qemu-devel@nongnu.org; Sun, 01 Mar 2009 12:38:30 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LdpcT-0002Un-UP
	for qemu-devel@nongnu.org; Sun, 01 Mar 2009 12:38:30 -0500
Received: from [199.232.76.173] (port=35253 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LdpcT-0002Ua-Oa
	for qemu-devel@nongnu.org; Sun, 01 Mar 2009 12:38:29 -0500
Received: from moutng.kundenserver.de ([212.227.17.9]:63213)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1LdpcT-0003KL-7B
	for qemu-devel@nongnu.org; Sun, 01 Mar 2009 12:38:29 -0500
Received: from localhost ([127.0.0.1] ident=stefan)
	by flocke.weilnetz.de with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1LdpcP-0001as-M0
	for qemu-devel@nongnu.org; Sun, 01 Mar 2009 18:38:25 +0100
Message-ID: <49AAC811.8070600@mail.berlios.de>
Date: Sun, 01 Mar 2009 18:38:25 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix some compiler warnings for windows
References: <4995E56F.4080200@mail.berlios.de>	<49AA65B9.8000709@mail.berlios.de>
	<Pine.LNX.4.64.0903011459110.2764@linmac.oyster.ru>
In-Reply-To: <Pine.LNX.4.64.0903011459110.2764@linmac.oyster.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

malc schrieb:
> On Sun, 1 Mar 2009, Stefan Weil wrote:
>
>   
>> Stefan Weil schrieb:
>>     
>>> Hello,
>>>
>>> this patch fixes some warnings for compilation with mingw32.
>>>
>>> Regards
>>> Stefan Weil
>>>       
>> Here is an update of my patch for the current Qemu trunk.
>> It reduces the number of warnings for win32 from 256 to 67.
>>
>> At least one warning indicates an error in Qemu for Windows:
>> vl.c:5386: warning: fds[1] is used uninitialized in this function
>> This was fixed, too.
>>
>> Could one of the maintainers please apply this patch to Qemu trunk?
>>     
>
> Index: trunk/block-raw-win32.c
> ===================================================================
> --- trunk.orig/block-raw-win32.c        2009-03-01 11:04:03.000000000 
> +0100
> +++ trunk/block-raw-win32.c     2009-03-01 11:04:10.000000000 +0100
> @@ -279,7 +279,7 @@
>  static int raw_truncate(BlockDriverState *bs, int64_t offset)
>  {
>      BDRVRawState *s = bs->opaque;
> -    DWORD low, high;
> +    LONG low, high;
>  
>      low = offset;
>      high = offset >> 32;
> @@ -301,7 +301,8 @@
>  
>      switch(s->type) {
>      case FTYPE_FILE:
> -        l.LowPart = GetFileSize(s->hfile, &l.HighPart);
> +        l.LowPart = GetFileSize(s->hfile, &count);
> +        l.HighPart = count;
>          if (l.LowPart == 0xffffffffUL && GetLastError() != NO_ERROR)
>              return -EIO;
>          break;
>
> [..snip..]
>
> http://msdn.microsoft.com/en-us/library/aa364955(VS.85).aspx
> DWORD WINAPI GetFileSize(
>   __in       HANDLE hFile,
>   __out_opt  LPDWORD lpFileSizeHigh
> );
>
> IOW LONG doesn't seem to be correct.
>
>   

LONG low, high belongs to a call to SetFilePointer which takes LONG, PLONG
arguments: http://msdn.microsoft.com/en-us/library/aa365541(VS.85).aspx

GetFileSize is in another function.

Everything (not really, but more than now) will be correct, when my patch
is finally applied :-)

Regards
Stefan