From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Le6Z0-0002cP-VX for qemu-devel@nongnu.org; Mon, 02 Mar 2009 06:44:03 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Le6Yz-0002bv-BN for qemu-devel@nongnu.org; Mon, 02 Mar 2009 06:44:02 -0500 Received: from [199.232.76.173] (port=46506 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Le6Yz-0002bs-46 for qemu-devel@nongnu.org; Mon, 02 Mar 2009 06:44:01 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:44656) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Le6Yy-0000FR-Qs for qemu-devel@nongnu.org; Mon, 02 Mar 2009 06:44:00 -0500 Message-ID: <49ABC4CA.8070406@eu.citrix.com> Date: Mon, 2 Mar 2009 11:36:42 +0000 From: Stefano Stabellini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] VMware SVGA uses incorrect depth References: <4999DA28.3040404@moose.net> <49A842CD.1000306@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" andrzej zaborowski wrote: > I don't think hardcoding any depth is correct (not counting the > obvious performance disadvantage). The s->depth value is what is > returned by the SVGA_REG_HOST_BITS_PER_PIXEL register, so it should be > the host's color depth if possible (may be impossible for VNC, but > easy with SDL), iirc this broke only recently. > The problem is that the SDL frontend is initialized after the graphic device so it is not possible to get the host resolution from sdl.c at the time. That said, I think that setting the vmware svga color depth to s->depth = 24; s->bypp = 4; by default is reasonable since it covers 99% of the cases out there.