From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Le9nc-0006kM-19 for qemu-devel@nongnu.org; Mon, 02 Mar 2009 10:11:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Le9nY-0006eW-CW for qemu-devel@nongnu.org; Mon, 02 Mar 2009 10:11:19 -0500 Received: from [199.232.76.173] (port=40000 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Le9nY-0006eI-2k for qemu-devel@nongnu.org; Mon, 02 Mar 2009 10:11:16 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:55826) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Le9nX-0004re-IO for qemu-devel@nongnu.org; Mon, 02 Mar 2009 10:11:15 -0500 Message-ID: <49ABF706.6060807@mail.berlios.de> Date: Mon, 02 Mar 2009 16:11:02 +0100 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Add QEMU_NORETURN to some functions References: <4995E9A8.6030403@mail.berlios.de> <4999892F.6030900@us.ibm.com> <4999ABFA.80506@mail.berlios.de> <49A9673D.8000805@mail.berlios.de> <49A9B0C4.3090606@us.ibm.com> <49A9B7A0.7030606@mail.berlios.de> <49AB1BC8.2060309@us.ibm.com> <49AB953B.2050802@mail.berlios.de> <49ABEAF6.10502@us.ibm.com> In-Reply-To: <49ABEAF6.10502@us.ibm.com> Content-Type: multipart/mixed; boundary="------------080104080102080509030408" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: QEMU Developers This is a multi-part message in MIME format. --------------080104080102080509030408 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Anthony Liguori schrieb: > Stefan Weil wrote: >> Would a patch which only adds noreturn to header files be accepted? > > Yup. > > Regards, > > Anthony Liguori Here is an extract of my previous patch. This new patch adds the noreturn attribute only to global functions declared in header files. Regards Stefan Weil --------------080104080102080509030408 Content-Type: text/x-diff; name="noreturn.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="noreturn.patch" Add missing QEMU_NORETURN attribute to several global functions. Signed-off-by: Stefan Weil Index: trunk/bsd-user/qemu.h =================================================================== --- trunk.orig/bsd-user/qemu.h 2009-03-01 11:04:00.000000000 +0100 +++ trunk/bsd-user/qemu.h 2009-03-02 15:48:59.000000000 +0100 @@ -136,7 +136,7 @@ abi_long arg5, abi_long arg6); void gemu_log(const char *fmt, ...) __attribute__((format(printf,1,2))); extern THREAD CPUState *thread_env; -void cpu_loop(CPUState *env, enum BSDType bsd_type); +void QEMU_NORETURN cpu_loop(CPUState *env, enum BSDType bsd_type); void init_paths(const char *prefix); const char *path(const char *pathname); char *target_strerror(int err); Index: trunk/darwin-user/qemu.h =================================================================== --- trunk.orig/darwin-user/qemu.h 2009-03-01 11:04:01.000000000 +0100 +++ trunk/darwin-user/qemu.h 2009-03-02 15:48:59.000000000 +0100 @@ -105,7 +105,7 @@ void write_dt(void *ptr, unsigned long addr, unsigned long limit, int flags); extern CPUState *global_env; -void cpu_loop(CPUState *env); +void QEMU_NORETURN cpu_loop(CPUState *env); void init_paths(const char *prefix); const char *path(const char *pathname); Index: trunk/exec-all.h =================================================================== --- trunk.orig/exec-all.h 2009-03-01 11:04:00.000000000 +0100 +++ trunk/exec-all.h 2009-03-02 15:48:59.000000000 +0100 @@ -74,8 +74,8 @@ int cpu_restore_state_copy(struct TranslationBlock *tb, CPUState *env, unsigned long searched_pc, void *puc); -void cpu_resume_from_signal(CPUState *env1, void *puc); -void cpu_io_recompile(CPUState *env, void *retaddr); +void QEMU_NORETURN cpu_resume_from_signal(CPUState *env1, void *puc); +void QEMU_NORETURN cpu_io_recompile(CPUState *env, void *retaddr); TranslationBlock *tb_gen_code(CPUState *env, target_ulong pc, target_ulong cs_base, int flags, int cflags); Index: trunk/linux-user/qemu.h =================================================================== --- trunk.orig/linux-user/qemu.h 2009-03-01 11:04:01.000000000 +0100 +++ trunk/linux-user/qemu.h 2009-03-02 15:48:59.000000000 +0100 @@ -174,7 +174,7 @@ abi_long arg5, abi_long arg6); void gemu_log(const char *fmt, ...) __attribute__((format(printf,1,2))); extern THREAD CPUState *thread_env; -void cpu_loop(CPUState *env); +void QEMU_NORETURN cpu_loop(CPUState *env); void init_paths(const char *prefix); const char *path(const char *pathname); char *target_strerror(int err); Index: trunk/target-arm/exec.h =================================================================== --- trunk.orig/target-arm/exec.h 2009-03-01 11:04:00.000000000 +0100 +++ trunk/target-arm/exec.h 2009-03-02 15:48:59.000000000 +0100 @@ -55,4 +55,4 @@ #include "softmmu_exec.h" #endif -void raise_exception(int); +void QEMU_NORETURN raise_exception(int); --------------080104080102080509030408--