From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LeEte-00005a-AC for qemu-devel@nongnu.org; Mon, 02 Mar 2009 15:37:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LeEtb-0008VN-BE for qemu-devel@nongnu.org; Mon, 02 Mar 2009 15:37:53 -0500 Received: from [199.232.76.173] (port=35400 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LeEtb-0008VK-4G for qemu-devel@nongnu.org; Mon, 02 Mar 2009 15:37:51 -0500 Received: from mailout.artfiles.de ([80.252.97.80]:34815) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LeEta-0004GS-Mf for qemu-devel@nongnu.org; Mon, 02 Mar 2009 15:37:50 -0500 Received: from [77.128.105.216] (helo=[192.168.0.4]) auth=rr@bttr-software.de by mailout.artfiles.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) id 1LeEtW-0000qS-80 for qemu-devel@nongnu.org; Mon, 02 Mar 2009 21:37:46 +0100 Message-ID: <49AC4399.70902@bttr-software.de> Date: Mon, 02 Mar 2009 21:37:45 +0100 From: Robert Riebisch MIME-Version: 1.0 Subject: Re: [Qemu-devel] [Patch] [Resend] Fix sigsegv on Windows host References: In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Consul wrote: > Is there a reason this patch has not been applied? I'm still getting sigsegv early in the boot of Windows images without it. > s->bounce has been VirtualAlloc'ed and should be VirtualFree'ed. > > signed-off-by Alex Ivanov > > --- block.c (revision 6653) > +++ block.c (working copy) > @@ -1263,7 +1263,7 @@ > if (!s->is_write) { > qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size); > } > - qemu_free(s->bounce); > + qemu_vfree(s->bounce); > s->this_aiocb->cb(s->this_aiocb->opaque, ret); > qemu_aio_release(s->this_aiocb); > } Could someone please apply this to SVN?! Thanks! Robert Riebisch -- BTTR Software http://www.bttr-software.de/