From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LeFZK-0005Tk-JT for qemu-devel@nongnu.org; Mon, 02 Mar 2009 16:20:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LeFZH-0005SO-Nt for qemu-devel@nongnu.org; Mon, 02 Mar 2009 16:20:58 -0500 Received: from [199.232.76.173] (port=34419 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LeFZH-0005SC-C5 for qemu-devel@nongnu.org; Mon, 02 Mar 2009 16:20:55 -0500 Received: from qw-out-1920.google.com ([74.125.92.149]:27247) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LeFZG-0005Zq-Sj for qemu-devel@nongnu.org; Mon, 02 Mar 2009 16:20:55 -0500 Received: by qw-out-1920.google.com with SMTP id 4so1895243qwk.4 for ; Mon, 02 Mar 2009 13:20:54 -0800 (PST) Message-ID: <49AC4DB3.4030807@codemonkey.ws> Date: Mon, 02 Mar 2009 15:20:51 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [Patch] [Resend] Fix sigsegv on Windows host References: <49AC4399.70902@bttr-software.de> In-Reply-To: <49AC4399.70902@bttr-software.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Robert Riebisch wrote: > Consul wrote: > > >> Is there a reason this patch has not been applied? I'm still getting sigsegv early in the boot of Windows images without it. >> s->bounce has been VirtualAlloc'ed and should be VirtualFree'ed. >> >> signed-off-by Alex Ivanov >> >> --- block.c (revision 6653) >> +++ block.c (working copy) >> @@ -1263,7 +1263,7 @@ >> if (!s->is_write) { >> qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size); >> } >> - qemu_free(s->bounce); >> + qemu_vfree(s->bounce); >> s->this_aiocb->cb(s->this_aiocb->opaque, ret); >> qemu_aio_release(s->this_aiocb); >> } >> > > Could someone please apply this to SVN?! Thanks! > It's in my queue to be applied before the release so it'll be there soon. Regards, Anthony Liguori > Robert Riebisch >