From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LfBPy-0001sb-Cq for qemu-devel@nongnu.org; Thu, 05 Mar 2009 06:07:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LfBPr-0001sP-Md for qemu-devel@nongnu.org; Thu, 05 Mar 2009 06:07:08 -0500 Received: from [199.232.76.173] (port=59594 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfBPr-0001sM-Ir for qemu-devel@nongnu.org; Thu, 05 Mar 2009 06:07:03 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:2056) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LfBPr-0005Ie-5y for qemu-devel@nongnu.org; Thu, 05 Mar 2009 06:07:03 -0500 Received: from [10.80.225.184] ([10.80.225.184]) by smtp01.ad.xensource.com (8.13.1/8.13.1) with ESMTP id n25B6wRD029917 for ; Thu, 5 Mar 2009 03:06:59 -0800 Message-ID: <49AFB216.6070300@eu.citrix.com> Date: Thu, 05 Mar 2009 11:05:58 +0000 From: Stefano Stabellini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [6683] Update cocoa.m to match new DisplayState code (Samuel Benson) References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" Anthony Liguori wrote: > Revision: 6683 > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6683 > Author: aliguori > Date: 2009-03-04 19:25:22 +0000 (Wed, 04 Mar 2009) > Log Message: > ----------- > Update cocoa.m to match new DisplayState code (Samuel Benson) > > Version 2 does as follows: > > [1]: Corrects endianness on issues by using native BGR to RGB conversion > [2]: Uses DisplayState accessors for obtaining graphics context information, > which > [3]: Removes now unused variables, and > [4]: Allows reading of varying color modes (32bit/24/16), and converting to > native colorspace > [5]: Attempts to keep itself centered on screen (as opposed to bottom right, > which immediately goes off screen after bios load) on context changes > (window resizes) > > Testing working on i386 (gentoo, Windows 2000) and PPC (debian) guests on PPC > and x86 Macs. > > In regards to [4], Windows 2000 displays fine on quick tests, but on the lowest > setting I could test, 16bit color depth at 4bpp, colors are slightly off. I > used gentoo install-x86-minimal-2008.0 in framebuffer mode to test above > setting; the usual grey text is now blue, and Tux appears to be BGR shifted. I > do not know if previous code worked at such a low color setting. > > Signed-off-by: Samuel Benson > Please read this message: http://lists.gnu.org/archive/html/qemu-devel/2009-03/msg00034.html