From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LfIqd-0005iE-Ra
	for qemu-devel@nongnu.org; Thu, 05 Mar 2009 14:03:11 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LfIqc-0005hG-6z
	for qemu-devel@nongnu.org; Thu, 05 Mar 2009 14:03:11 -0500
Received: from [199.232.76.173] (port=51495 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LfIqc-0005hB-0x
	for qemu-devel@nongnu.org; Thu, 05 Mar 2009 14:03:10 -0500
Received: from e6.ny.us.ibm.com ([32.97.182.146]:55395)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LfIqb-0005Ea-HU
	for qemu-devel@nongnu.org; Thu, 05 Mar 2009 14:03:09 -0500
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n25J4EcI016993
	for <qemu-devel@nongnu.org>; Thu, 5 Mar 2009 14:04:14 -0500
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n25J38Bp195440
	for <qemu-devel@nongnu.org>; Thu, 5 Mar 2009 14:03:08 -0500
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n25J1osa028479
	for <qemu-devel@nongnu.org>; Thu, 5 Mar 2009 14:01:50 -0500
Message-ID: <49B021EB.1060405@us.ibm.com>
Date: Thu, 05 Mar 2009 13:03:07 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix cpuid KVM crash on i386
References: <1236088698.24907.3.camel@localhost.localdomain>
In-Reply-To: <1236088698.24907.3.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: avi@redhat.com

Lubomir Rintel wrote:
> Cpuid should return into vec, not overwrite past address in count.
> Changeset 6565 broke this.
>   

Applied to both stable and trunk.  Thanks.

Regards,

Anthony Liguori

> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> Index: target-i386/helper.c
> ===================================================================
> --- target-i386/helper.c	(revision 6676)
> +++ target-i386/helper.c	(working copy)
> @@ -1418,10 +1418,10 @@
>  #else
>      asm volatile("pusha \n\t"
>                   "cpuid \n\t"
> -                 "mov %%eax, 0(%1) \n\t"
> -                 "mov %%ebx, 4(%1) \n\t"
> -                 "mov %%ecx, 8(%1) \n\t"
> -                 "mov %%edx, 12(%1) \n\t"
> +                 "mov %%eax, 0(%2) \n\t"
> +                 "mov %%ebx, 4(%2) \n\t"
> +                 "mov %%ecx, 8(%2) \n\t"
> +                 "mov %%edx, 12(%2) \n\t"
>                   "popa"
>                   : : "a"(function), "c"(count), "S"(vec)
>                   : "memory", "cc");
>
>
>
>
>
>