* [Qemu-devel] [PATCH] Fix cpuid KVM crash on i386
@ 2009-03-03 13:58 Lubomir Rintel
2009-03-05 19:03 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Lubomir Rintel @ 2009-03-03 13:58 UTC (permalink / raw)
To: qemu-devel; +Cc: avi
Cpuid should return into vec, not overwrite past address in count.
Changeset 6565 broke this.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Index: target-i386/helper.c
===================================================================
--- target-i386/helper.c (revision 6676)
+++ target-i386/helper.c (working copy)
@@ -1418,10 +1418,10 @@
#else
asm volatile("pusha \n\t"
"cpuid \n\t"
- "mov %%eax, 0(%1) \n\t"
- "mov %%ebx, 4(%1) \n\t"
- "mov %%ecx, 8(%1) \n\t"
- "mov %%edx, 12(%1) \n\t"
+ "mov %%eax, 0(%2) \n\t"
+ "mov %%ebx, 4(%2) \n\t"
+ "mov %%ecx, 8(%2) \n\t"
+ "mov %%edx, 12(%2) \n\t"
"popa"
: : "a"(function), "c"(count), "S"(vec)
: "memory", "cc");
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] Fix cpuid KVM crash on i386
2009-03-03 13:58 [Qemu-devel] [PATCH] Fix cpuid KVM crash on i386 Lubomir Rintel
@ 2009-03-05 19:03 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2009-03-05 19:03 UTC (permalink / raw)
To: qemu-devel; +Cc: avi
Lubomir Rintel wrote:
> Cpuid should return into vec, not overwrite past address in count.
> Changeset 6565 broke this.
>
Applied to both stable and trunk. Thanks.
Regards,
Anthony Liguori
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> Index: target-i386/helper.c
> ===================================================================
> --- target-i386/helper.c (revision 6676)
> +++ target-i386/helper.c (working copy)
> @@ -1418,10 +1418,10 @@
> #else
> asm volatile("pusha \n\t"
> "cpuid \n\t"
> - "mov %%eax, 0(%1) \n\t"
> - "mov %%ebx, 4(%1) \n\t"
> - "mov %%ecx, 8(%1) \n\t"
> - "mov %%edx, 12(%1) \n\t"
> + "mov %%eax, 0(%2) \n\t"
> + "mov %%ebx, 4(%2) \n\t"
> + "mov %%ecx, 8(%2) \n\t"
> + "mov %%edx, 12(%2) \n\t"
> "popa"
> : : "a"(function), "c"(count), "S"(vec)
> : "memory", "cc");
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-05 19:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-03 13:58 [Qemu-devel] [PATCH] Fix cpuid KVM crash on i386 Lubomir Rintel
2009-03-05 19:03 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).