qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [6721] Refactor keymap code to avoid duplication ("Daniel P.
Date: Fri, 06 Mar 2009 21:08:06 -0600	[thread overview]
Message-ID: <49B1E516.3070504@codemonkey.ws> (raw)
In-Reply-To: <alpine.DEB.1.00.0903070351510.10279@pacific.mpi-cbg.de>

Johannes Schindelin wrote:
>> The new file keymaps.h is missing.
>>     
>
> Anthony, as you seem to use Git from time to time, you might be interested 
> in using git-svn, to overcome such omissions.
>   

guilt failed me here.

I have scripts that pull patches from the mailing list (basically, 
git-am but a lot more forgiving) and converts that to a series of 
patches for guilt.  I think use the guilt tree on top of a git tree 
which I use to automatically build/test each patch in a series.  After 
this, I think do more exhaustive testing of the whole series applied.

I think have another script that will apply the whole series to SVN.  
It's smart enough to read the patch files to determine what files have 
been added/removed and issue the appropriate svn add/rm command.  
Basically, this is an svn-import command.

With this particular series, it didn't apply to trunk anymore so I did 
some fixups.  Unfortunately, guilt has a long standing bug where it can 
sometimes lose track of files introduced by a patch.  This happened so I 
had to manually git add && guilt refresh to add the files back to the 
patch.  The curious thing is that somehow, in the process of this, 
instead of having diff /dev/null b/foo.h, it did diff a/foo.h b/foo.h 
and treated foo.h as an empty file.  This means that my svn-import 
script didn't catch it as an added file.  I've fixed this by adding an 
svn status check to ensure no stray files are around.

What I'd really like to do, is switch over to just using git-am and then 
push the patches to a git tree.  But I jump through all of the above 
hoops to accommodate people that send patches that aren't git-am 
friendly (which is the majority today) and to morph command messages 
into the format that QEMU has traditionally used.

One of the issues of converting over to git is that Savannah doesn't 
really have a robust git hosting mechanism.  Each project can have one 
tree.  I also am not sure that there's a reasonable mechanism to do 
commit hooks to enable mailing list messages.  Savannah also requires 
that the main code repository be hosted in Savannah so it wouldn't be an 
option to continue using Savannah services but host the git tree 
somewhere else.

Regards,

Anthony Liguori

> Hth,
> Dscho
>
>   

  reply	other threads:[~2009-03-07  3:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06 20:27 [Qemu-devel] [6721] Refactor keymap code to avoid duplication ("Daniel P Anthony Liguori
2009-03-06 21:25 ` Stefan Weil
2009-03-07  2:52   ` Johannes Schindelin
2009-03-07  3:08     ` Anthony Liguori [this message]
2009-03-07 10:19       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B1E516.3070504@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).