From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LgKoW-0001nZ-9r
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:21:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LgKoT-0001nL-Tm
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:21:15 -0400
Received: from [199.232.76.173] (port=52526 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LgKoT-0001nI-P1
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:21:13 -0400
Received: from an-out-0708.google.com ([209.85.132.248]:64020)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LgKoT-0001q6-EB
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:21:13 -0400
Received: by an-out-0708.google.com with SMTP id b6so592482ana.37
	for <qemu-devel@nongnu.org>; Sun, 08 Mar 2009 08:21:11 -0700 (PDT)
Message-ID: <49B3E265.1040205@codemonkey.ws>
Date: Sun, 08 Mar 2009 10:21:09 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6736] Sparse fixes: NULL use, header order, ANSI
	prototypes, static
References: <E1LfyWH-0006ll-Ie@cvs.savannah.gnu.org>
In-Reply-To: <E1LfyWH-0006ll-Ie@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>

Blue Swirl wrote:
> Revision: 6736
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6736
> Author:   blueswir1
> Date:     2009-03-07 15:32:56 +0000 (Sat, 07 Mar 2009)
> Log Message:
> -----------
> Sparse fixes: NULL use, header order, ANSI prototypes, static
>
> Fix Sparse warnings:
>  * use NULL instead of plain 0
>  * rearrange header include order to avoid redefining types accidentally
>  * ANSIfy SLIRP
>  * avoid "restrict" keyword
>  * add static
>   

This broke the Windows build.  The reason is that you moved all system 
headers to be included before any QEMU headers.  While I agree with this 
in principle, Windows headers are sloppy and don't include their 
dependencies.  Right now, we rely on qemu-common.h being included in the 
top in order to get #include <windows.h> every where.

To complicate matters further, we define some special versioning magic 
to get windows IPv6 support working.  I don't want to add that full blob 
to every .c file so it makes sense to use a qemu include file (like 
qemu-common.h).  That defeats that purpose of your refactoring though so 
I wanted to see what you thought about it.

Regards,

Anthony Liguori