From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LgLMf-0006LP-T4
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:56:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LgLMe-0006Jr-VB
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:56:33 -0400
Received: from [199.232.76.173] (port=36489 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LgLMe-0006Jg-SQ
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:56:32 -0400
Received: from fmmailgate03.web.de ([217.72.192.234]:37219)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1LgLMe-0006YX-7p
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 11:56:32 -0400
Message-ID: <49B3EAA8.6050900@web.de>
Date: Sun, 08 Mar 2009 16:56:24 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <E1LeyCK-0007nk-NI@cvs.savannah.gnu.org>
In-Reply-To: <E1LeyCK-0007nk-NI@cvs.savannah.gnu.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig26EE06664E7EF3D735C8A9E9"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [6684] Fix "info registers" under kvm.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig26EE06664E7EF3D735C8A9E9
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Andrzej Zaborowski wrote:
> Revision: 6684
>           http://svn.sv.gnu.org/viewvc/?view=3Drev&root=3Dqemu&revision=
=3D6684
> Author:   balrog
> Date:     2009-03-04 21:00:07 +0000 (Wed, 04 Mar 2009)
> Log Message:
> -----------
> Fix "info registers" under kvm.
>=20
> Modified Paths:
> --------------
>     trunk/target-i386/helper.c
>=20
> Modified: trunk/target-i386/helper.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- trunk/target-i386/helper.c	2009-03-04 19:25:22 UTC (rev 6683)
> +++ trunk/target-i386/helper.c	2009-03-04 21:00:07 UTC (rev 6684)
> @@ -578,6 +578,9 @@
>      char cc_op_name[32];
>      static const char *seg_name[6] =3D { "ES", "CS", "SS", "DS", "FS",=
 "GS" };
> =20
> +    if (kvm_enabled())
> +        kvm_arch_get_registers(env);
> +
>      eflags =3D env->eflags;
>  #ifdef TARGET_X86_64
>      if (env->hflags & HF_CS64_MASK) {
>=20

On the one hand, this patch also takes care of sync'ing with KVM in case
of cpu_dump_state on fatal exists. On the other hand, it only solves one
part of monitor issue. See [1] for a more complete sync.

I'm just still waiting for a reply from Anthony on how to embed best all
the "if (kvm_enabled()) foo();" patterns [2]. That would also allow us
to merge gdbstub support for upstream kvm.

Jan

[1] http://permalink.gmane.org/gmane.comp.emulators.qemu/36994
[2] http://permalink.gmane.org/gmane.comp.emulators.qemu/37067


--------------enig26EE06664E7EF3D735C8A9E9
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkmz6q4ACgkQniDOoMHTA+ktZgCeIpAtOuNe+qWE3kuGAE41PPwv
7HAAn2/vLuCdD1jW0E5vJeo2+A1ppo8W
=nG6l
-----END PGP SIGNATURE-----

--------------enig26EE06664E7EF3D735C8A9E9--