From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LgLQ6-00088v-2s for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:00:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LgLQ4-00087Y-D8 for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:00:05 -0400 Received: from [199.232.76.173] (port=36521 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LgLQ3-00087R-G0 for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:00:03 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:57021) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LgLQ2-00074X-FU for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:00:03 -0400 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate01.web.de (Postfix) with ESMTP id 83F83FE5933F for ; Sun, 8 Mar 2009 17:00:01 +0100 (CET) Received: from [88.65.240.115] (helo=[192.168.1.4]) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #277) id 1LgLQ1-0005sL-00 for qemu-devel@nongnu.org; Sun, 08 Mar 2009 17:00:01 +0100 Message-ID: <49B3EB80.6080901@web.de> Date: Sun, 08 Mar 2009 17:00:00 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <49B3D904.2090202@web.de> <761ea48b0903080803l7e481a96p4511076b7f69305a@mail.gmail.com> <49B3E5F3.3000209@web.de> <761ea48b0903080846p6a0c0bfcoc96dd2f37490dde0@mail.gmail.com> In-Reply-To: <761ea48b0903080846p6a0c0bfcoc96dd2f37490dde0@mail.gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig9F83780245F3CE8ED7660D80" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: dyngen-exec.h cleanup Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9F83780245F3CE8ED7660D80 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Laurent Desnogues wrote: > On Sun, Mar 8, 2009 at 4:36 PM, Jan Kiszka wrote: >> Laurent Desnogues wrote: >>> On Sun, Mar 8, 2009 at 3:41 PM, Jan Kiszka wrote:= >>>> Also, some discussion on this list suggested that it's more efficien= t to >>>> look into converting the remaining AREGS to TCG and finally do the >>>> ultimative "rm dyngen-exec.h". Don't you want to spend some time on = this >>>> already? >>> This requires modifying ARM translator which is the last one to use >>> AREGn with n>0. And don't all targets use AREG0 as a pointer to the >>> CPU state? >> Yes, but wasn't it you who suggested that all those users should be >> converted over to the tcg_global_reg API? >=20 > Yes, and I did the work for ARM. However when considering the > removal of AREG0, and after looking at generated code, I came > to the perhaps premature conclusion that removing it would not > bring me any speedup (at least for a not so register starved > target as x86_64). I don't think we are looking for speedup here, just for cleanup. Status quo regarding performance after a conversion would be more than fine IMHO= =2E >=20 >> There is surely some work to do, and that probably across all archs. B= ut >> the sooner we should start. dyngen-exec.h is a constant source of pain= >> when you try to introduce new headers or refactor existing ones. >=20 > Well dyngen-exec.h is long gone in my sources even though > AREG0 is still used. I would have to backtrack my changes to > see how I arrived to that, but for sure the first thing to do is to > remove cpu_T from ARM target. Yes, please share your wisdom! Jan --------------enig9F83780245F3CE8ED7660D80 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkmz64AACgkQniDOoMHTA+nrkQCdE8IhAXHtVZ3NgZoCoKi9Vx1k k+UAn2ugZyANuNvd/kKdxnQJRby7atud =aaQ7 -----END PGP SIGNATURE----- --------------enig9F83780245F3CE8ED7660D80--