From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LgLaP-0003v7-RV
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:10:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LgLaO-0003tw-0f
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:10:45 -0400
Received: from [199.232.76.173] (port=40004 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LgLaN-0003tp-Qa
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:10:43 -0400
Received: from an-out-0708.google.com ([209.85.132.250]:1457)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LgLaN-0000Ck-Bx
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:10:43 -0400
Received: by an-out-0708.google.com with SMTP id b6so597445ana.37
	for <qemu-devel@nongnu.org>; Sun, 08 Mar 2009 09:10:42 -0700 (PDT)
Message-ID: <49B3EE01.3090402@codemonkey.ws>
Date: Sun, 08 Mar 2009 11:10:41 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <E1LeyCK-0007nk-NI@cvs.savannah.gnu.org> <49B3EAA8.6050900@web.de>
In-Reply-To: <49B3EAA8.6050900@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [6684] Fix "info registers" under kvm.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org

Jan Kiszka wrote:
> Andrzej Zaborowski wrote:
>   
>> Revision: 6684
>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6684
>> Author:   balrog
>> Date:     2009-03-04 21:00:07 +0000 (Wed, 04 Mar 2009)
>> Log Message:
>> -----------
>> Fix "info registers" under kvm.
>>
>> Modified Paths:
>> --------------
>>     trunk/target-i386/helper.c
>>
>> Modified: trunk/target-i386/helper.c
>> ===================================================================
>> --- trunk/target-i386/helper.c	2009-03-04 19:25:22 UTC (rev 6683)
>> +++ trunk/target-i386/helper.c	2009-03-04 21:00:07 UTC (rev 6684)
>> @@ -578,6 +578,9 @@
>>      char cc_op_name[32];
>>      static const char *seg_name[6] = { "ES", "CS", "SS", "DS", "FS", "GS" };
>>  
>> +    if (kvm_enabled())
>> +        kvm_arch_get_registers(env);
>> +
>>      eflags = env->eflags;
>>  #ifdef TARGET_X86_64
>>      if (env->hflags & HF_CS64_MASK) {
>>
>>     
>
> On the one hand, this patch also takes care of sync'ing with KVM in case
> of cpu_dump_state on fatal exists. On the other hand, it only solves one
> part of monitor issue. See [1] for a more complete sync.
>
> I'm just still waiting for a reply from Anthony on how to embed best all
> the "if (kvm_enabled()) foo();" patterns [2]. That would also allow us
> to merge gdbstub support for upstream kvm.
>   

I really don't have a great suggestion.  I've been hoping we could come 
up with something better than if (kvm_enabled()) foo().  If we can't, we 
can't.

Regards,

Anthony Liguori

> Jan
>
> [1] http://permalink.gmane.org/gmane.comp.emulators.qemu/36994
> [2] http://permalink.gmane.org/gmane.comp.emulators.qemu/37067
>
>