From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LgLmc-0006rF-G7
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:23:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LgLmZ-0006qj-VH
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:23:21 -0400
Received: from [199.232.76.173] (port=46634 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LgLmZ-0006qf-OA
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:23:19 -0400
Received: from mx2.redhat.com ([66.187.237.31]:37297)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1LgLmZ-0002Fr-4c
	for qemu-devel@nongnu.org; Sun, 08 Mar 2009 12:23:19 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n28GNINg003139
	for <qemu-devel@nongnu.org>; Sun, 8 Mar 2009 12:23:18 -0400
Message-ID: <49B3F0F5.8020202@redhat.com>
Date: Sun, 08 Mar 2009 18:23:17 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [6684] Fix "info registers" under kvm.
References: <E1LeyCK-0007nk-NI@cvs.savannah.gnu.org> <49B3EAA8.6050900@web.de>
	<49B3EFDC.8050205@redhat.com>
In-Reply-To: <49B3EFDC.8050205@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Avi Kivity wrote:
> Jan Kiszka wrote:
>> I'm just still waiting for a reply from Anthony on how to embed best all
>> the "if (kvm_enabled()) foo();" patterns [2]. That would also allow us
>> to merge gdbstub support for upstream kvm.
>>
>>   
>
> Wouldn't 'if (!kvm_enabled()) return;' inside the callees suffice?

Rather,

static inline void kvm_foo(...)
{
    if (!kvm_enabled()) {
        return;
    }

#ifdef CONFIG_KVM
   kvm_do_foo();
#endif
}



-- 
error compiling committee.c: too many arguments to function