qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] Re: [6684] Fix "info registers" under kvm.
Date: Sun, 08 Mar 2009 11:40:43 -0500	[thread overview]
Message-ID: <49B3F50B.8060209@codemonkey.ws> (raw)
In-Reply-To: <49B3F333.4060504@web.de>

Jan Kiszka wrote:
> We could do
>
> static inline void kvm_get_registers(CPUState *env)
> {
> 	if (kvm_enabled())
> 		kvm_arch_get_registers(env);
> }
>
> in kvm.h (and kvm_put_registers analogously). That would still be
> kvm-specific, though, but it would reduce the impact on the code that
> has to be extended this way.
>
> Generic hooks is something I would really like to postpone here until we
> start working on some accelerator abstraction.
>   

I'd rather add hooks where we need them and then later take all of the 
hooks and build an abstraction from that.  Otherwise, you start 
inventing hooks that may not be needed.

BTW, Gerd, how close are we to seeing another round of Xen patches?  I 
think what's needed has shown up in the xen tree by now, correct?  Or 
are you still waiting for the DisplayState changes to get merged into 
Ian's tree?

Regards,

Anthony Liguori

> Jan
>
>   

  reply	other threads:[~2009-03-08 16:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04 21:00 [Qemu-devel] [6684] Fix "info registers" under kvm Andrzej Zaborowski
2009-03-08 15:56 ` [Qemu-devel] " Jan Kiszka
2009-03-08 16:10   ` Anthony Liguori
2009-03-08 16:32     ` Jan Kiszka
2009-03-08 16:40       ` Anthony Liguori [this message]
2009-03-09  7:46         ` Gerd Hoffmann
2009-03-08 16:35     ` Andreas Färber
2009-03-09  9:42       ` Avi Kivity
2009-03-08 16:18   ` Avi Kivity
2009-03-08 16:23     ` Avi Kivity
2009-03-08 16:36       ` Blue Swirl
2009-03-09  9:42         ` Avi Kivity
2009-03-08 16:36       ` Anthony Liguori
2009-03-09  9:41         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B3F50B.8060209@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=jan.kiszka@web.de \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).