From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lglml-0007BP-7f
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 16:09:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lglmi-00077s-Uw
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 16:09:14 -0400
Received: from [199.232.76.173] (port=36131 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lglmi-00077f-Eq
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 16:09:12 -0400
Received: from mx20.gnu.org ([199.232.41.8]:2559)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <avi@redhat.com>) id 1Lglmi-0006p0-7b
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 16:09:12 -0400
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1LggtB-0007Ns-88
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 10:55:33 -0400
Message-ID: <49B528B3.9020800@redhat.com>
Date: Mon, 09 Mar 2009 16:33:23 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [HaikuPorts-devs] [Qemu-devel] Re: [PATCH] [RFC] Haiku host
	support and general configure issues
References: <3165008770-BeMail@laptop>
In-Reply-To: <3165008770-BeMail@laptop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?RnJhbsOnb2lzIFJldm9s?= <revol@free.fr>
Cc: haikuports-devs@ports.haiku-files.org, qemu-devel@nongnu.org

Fran=C3=A7ois Revol wrote:
>> We could define a qemu_errno() which returns errno converted to=20
>> positive=20
>> numbers.  While it will touch a lot of places, I don't think it can=20
>> be=20
>> considered invasive.
>>    =20
>
> I'm used to using the opposite, RETERR() returning always negative=20
> codes from either errno or E*, and it works quite well.
>
> I don't see the point in making stuff positive to return them negated.
>  =20

Changing errno to qemu_errno() is not an invasive change (at least, not=20
much).  Adding a RETERR() is, with significant chance for regressions.

> Besides, one of the error codes in BeOS & Haiku will certainly overflow=
=20
> on 32bit (B_NO_MEMORY =3D B_GENERAL_ERROR_BASE =3D LONG_MIN).
>  =20

qemu_errno() on Haiku could change it to something else.

--=20
error compiling committee.c: too many arguments to function