From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lh6bC-0000H2-6x for qemu-devel@nongnu.org; Tue, 10 Mar 2009 14:22:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lh6b9-0000Gp-Lp for qemu-devel@nongnu.org; Tue, 10 Mar 2009 14:22:40 -0400 Received: from [199.232.76.173] (port=35817 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lh6b9-0000Gm-G9 for qemu-devel@nongnu.org; Tue, 10 Mar 2009 14:22:39 -0400 Received: from mail-fx0-f175.google.com ([209.85.220.175]:45620) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lh6b8-0001gu-Tb for qemu-devel@nongnu.org; Tue, 10 Mar 2009 14:22:39 -0400 Received: by fxm23 with SMTP id 23so1772462fxm.34 for ; Tue, 10 Mar 2009 11:22:37 -0700 (PDT) Message-ID: <49B6AFE8.9000600@codemonkey.ws> Date: Tue, 10 Mar 2009 13:22:32 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Compiling qemu with nas installed References: <200903082321.28196.hasso@estpak.ee> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Blue Swirl wrote: > On 3/8/09, Hasso Tepper wrote: > >> If user has packages installed in "nonstandard" paths (like pkgsrc package >> system used by NetBSD and DragonFly - /usr/pkg), CPPFLAGS and LDFLAGS are >> used normally by users to help configure scripts etc to find headers and >> libraries. >> >> $ export CPPFLAGS=-I/usr/pkg/include >> $ export LDFLAGS=-L/usr/pkg/lib >> >> This causes the problem if user has the nas software package installed: >> You should use --extra-cflags and --extra-ldflags. If we're not already making these come before our -I$(srcdir), then we should change that. Basically, we need to ensure that any of our headers have include priority over system headers in the search path. Regards, Anthony Liguori >> CC wm8750.o >> /tmp/q/wm8750.c:24: error: expected specifier-qualifier-list >> before 'QEMUSoundCard' >> /tmp/q/hw/wm8750.c: In function 'wm8750_in_load': >> /tmp/q/hw/wm8750.c:59: error: 'struct wm8750_s' has no member >> named 'idx_in' >> /tmp/q/hw/wm8750.c:59: error: 'struct wm8750_s' has no member >> named 'req_in' >> etc etc etc >> >> The problem comes from fact that the nas package has also audio/audio.h >> file and it's included in wm8750.c if user or package system defines >> CPPFLAGS which happen to include the path to the audio/audio.h from nas. >> >> I don't how to fix it correctly, but I think that local paths should be >> always before system or user specified ones. >> > > Rename audio/audio.h to audio/qemu_audio.h? > > >