From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LhOrC-0001By-3t
	for qemu-devel@nongnu.org; Wed, 11 Mar 2009 09:52:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LhOrA-00017w-DO
	for qemu-devel@nongnu.org; Wed, 11 Mar 2009 09:52:25 -0400
Received: from [199.232.76.173] (port=34815 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LhOrA-00017d-57
	for qemu-devel@nongnu.org; Wed, 11 Mar 2009 09:52:24 -0400
Received: from rv-out-0708.google.com ([209.85.198.241]:46704)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LhOr9-0007Yc-Jt
	for qemu-devel@nongnu.org; Wed, 11 Mar 2009 09:52:24 -0400
Received: by rv-out-0708.google.com with SMTP id f25so11394rvb.22
	for <qemu-devel@nongnu.org>; Wed, 11 Mar 2009 06:52:21 -0700 (PDT)
Message-ID: <49B7C212.6080002@codemonkey.ws>
Date: Wed, 11 Mar 2009 08:52:18 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Use of asprintf() breaks build on systems where
	asprintf() is not available
References: <Pine.NEB.4.64.0903102129500.11497@otaku.freeshell.org>
	<49B6E2F9.3020803@codemonkey.ws>
	<20090311104809.GA23995@redhat.com>
In-Reply-To: <20090311104809.GA23995@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

Daniel P. Berrange wrote:
> On Tue, Mar 10, 2009 at 05:00:25PM -0500, Anthony Liguori wrote:
>   
>> Palle Lyckegaard wrote:
>>     
>>> Hi,
>>>
>>> A few source-files, e.g. vnc.c, makes use of the (non-portable?) 
>>> asprintf() function, which is not available in e.g. Solaris 10 and 
>>> certain builds of OpenSolaris.
>>>
>>> What would be the proper "qemu" way of solving this problem? Creating 
>>> a library with the functions not avilable on the host system or 
>>> replacing the non-portable use(s) of the function(s) with proper 
>>> portable function(s)?
>>>       
>> Can you send in a patch to add the gnulib asprintf() with an appropriate 
>> configure test?
>>     
>
> I think it is just easier to remove the use of asprinf() from vnc.c It is
> only used once and not really all that hard to remove.
>   

That would be good too.

Regards,

Anthony Liguori

> Daniel
>