From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhPnP-0004vj-Vl for qemu-devel@nongnu.org; Wed, 11 Mar 2009 10:52:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhPnO-0004ux-4E for qemu-devel@nongnu.org; Wed, 11 Mar 2009 10:52:35 -0400 Received: from [199.232.76.173] (port=52160 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhPnN-0004ur-SE for qemu-devel@nongnu.org; Wed, 11 Mar 2009 10:52:33 -0400 Received: from mx2.redhat.com ([66.187.237.31]:60960) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LhPnN-0006AF-BD for qemu-devel@nongnu.org; Wed, 11 Mar 2009 10:52:33 -0400 Message-ID: <49B7D02E.1010307@redhat.com> Date: Wed, 11 Mar 2009 16:52:30 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: Problems KVM-84 References: <49B79D50.4090300@redhat.com> <49B7C6BF.6030803@codemonkey.ws> In-Reply-To: <49B7C6BF.6030803@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jay Mann , Uri Lublin , kvm@vger.kernel.org Anthony Liguori wrote: >> >> Scanning the file at startup is slow. We need to find a better way. > > Any quick ideas? Seems like this is broken by design. I agree. > Unless we can find a quick fix, I'm going to revert this in the stable > tree. We could cache the value in some unused area. Set it up in qemu-img. Don't support it on older images. But that's not a quick fix; I'd suggest reverting it in both stable and mainline, and re-applying in mainline when there's a fix. -- error compiling committee.c: too many arguments to function