From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Li9LS-0003nK-3b for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:30:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Li9LK-0003h6-SP for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:30:45 -0400 Received: from [199.232.76.173] (port=33943 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Li9LK-0003gv-IH for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:30:38 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:60437) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Li9LJ-0003Yn-Lk for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:30:38 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e7.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2DFLUZD010752 for ; Fri, 13 Mar 2009 11:21:30 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n2DFUN74176500 for ; Fri, 13 Mar 2009 11:30:23 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n2DFT0nb022912 for ; Fri, 13 Mar 2009 11:29:00 -0400 Received: from squirrel.codemonkey.ws (sig-9-65-48-130.mts.ibm.com [9.65.48.130]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n2DFStPd022470 for ; Fri, 13 Mar 2009 11:28:57 -0400 Message-ID: <49BA7C09.5080902@us.ibm.com> Date: Fri, 13 Mar 2009 10:30:17 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] DisplayAllocator interface References: <49AFF01B.8070505@eu.citrix.com> In-Reply-To: <49AFF01B.8070505@eu.citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefano Stabellini wrote: > Hi all, > this patch adds a DisplayAllocator interface that allows display > frontends (sdl in particular) to provide a preallocated display buffer > for the graphical backend to use. > > Whenever a graphical backend cannot use > qemu_create_displaysurface_from because its own internal pixel format > cannot be exported directly (text mode or graphical mode with color > depth 8 or 24), it creates another display buffer in memory using > qemu_create_displaysurface and does the conversion. > This new buffer needs to be blitted into the sdl surface buffer every time > we need to update portions of the screen. > We can avoid this using the DisplayAllocator interace: sdl provides its > own implementation of qemu_create_displaysurface, giving back the sdl > surface buffer directly (as we used to do before the DisplayState > changes). > Since the buffer returned by sdl could be in bgr format we need to put > back in the handlers of that case. > Applied. Thanks. Regards, Anthony Liguori