From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Li9Li-00043b-9k for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:31:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Li9Ld-0003xM-CG for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:31:01 -0400 Received: from [199.232.76.173] (port=33949 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Li9Ld-0003xE-8h for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:30:57 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:47613) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Li9Lc-0003bt-TX for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:30:57 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2DFSC8B016481 for ; Fri, 13 Mar 2009 11:28:12 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n2DFUtpt184190 for ; Fri, 13 Mar 2009 11:30:55 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n2DFTW0q026193 for ; Fri, 13 Mar 2009 11:29:32 -0400 Received: from squirrel.codemonkey.ws (sig-9-65-48-130.mts.ibm.com [9.65.48.130]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n2DFTVaI026091 for ; Fri, 13 Mar 2009 11:29:32 -0400 Message-ID: <49BA7C2E.2040503@us.ibm.com> Date: Fri, 13 Mar 2009 10:30:54 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] remove is_graphic_console from vga.c References: <49AFFBFB.3080706@eu.citrix.com> In-Reply-To: <49AFFBFB.3080706@eu.citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefano Stabellini wrote: > Hi all, > since vga_draw_graphic is only called by vga_hw_update when the console > associated with the graphic card is active, we don't need to check if > the current console is active using is_graphic_console. > > I suspect I introduced these checks when the console switching mechanism > didn't work as it does now. > > Applied. Thanks. Regards, Anthony Liguori