From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Li9MK-0004rk-9m for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:31:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Li9MF-0004kR-BK for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:31:39 -0400 Received: from [199.232.76.173] (port=33964 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Li9MF-0004k8-5K for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:31:35 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:33333) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Li9ME-0003gU-J2 for qemu-devel@nongnu.org; Fri, 13 Mar 2009 11:31:34 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2DFWlME011442 for ; Fri, 13 Mar 2009 11:32:47 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n2DFVXd2187520 for ; Fri, 13 Mar 2009 11:31:33 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n2DFUAnf028664 for ; Fri, 13 Mar 2009 11:30:10 -0400 Received: from squirrel.codemonkey.ws (sig-9-65-48-130.mts.ibm.com [9.65.48.130]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n2DFU93r028614 for ; Fri, 13 Mar 2009 11:30:10 -0400 Message-ID: <49BA7C54.6080207@us.ibm.com> Date: Fri, 13 Mar 2009 10:31:32 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] Add and use remaining #defines for PCI device IDs References: <20090307211959.GA11120@miranda.arrow> In-Reply-To: <20090307211959.GA11120@miranda.arrow> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stuart Brady wrote: > This patch adds and uses #defines for the remaining hardcoded PCI > device IDs. It also moves definitions taken from linux/pci_ids.h > into a separate header (hw/pci_ids.h), removes the 'RTL' from > PCI_DEVICE_ID_REALTEK_RTL8029, and renames PCI_DEVICE_ID_FSL_E500 > to PCI_DEVICE_ID_MPC8533E to match Linux's definition. > > Changes in v2: > * Don't use C99-style comments > * Move definitions from linux/pci_ids.h into a separate header > * Rename PCI_DEVICE_ID_FSL_E500 to PCI_DEVICE_ID_MPC8533E > > Signed-off-by: Stuart Brady > Applied. Thanks. Regards, Anthony Liguori