From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] make qemu_announce_self handle non contiguous net tables
Date: Fri, 13 Mar 2009 11:19:45 -0500 [thread overview]
Message-ID: <49BA87A1.9080605@us.ibm.com> (raw)
In-Reply-To: <20090311182503.GA18711@amt.cnet>
Marcelo Tosatti wrote:
> With hotplug nd_table might contain holes.
>
> Noticed by Eduardo Habkost.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
Applied to both trunk and stable. Thanks.
Regards,
Anthony Liguori
> Index: savevm.c
> ===================================================================
> --- savevm.c (revision 6811)
> +++ savevm.c (working copy)
> @@ -122,7 +122,9 @@
> VLANClientState *vc;
> uint8_t buf[256];
>
> - for (i = 0; i < nb_nics; i++) {
> + for (i = 0; i < MAX_NICS; i++) {
> + if (!nd_table[i].used)
> + continue;
> len = announce_self_create(buf, nd_table[i].macaddr);
> vlan = nd_table[i].vlan;
> for(vc = vlan->first_client; vc != NULL; vc = vc->next) {
>
>
>
>
prev parent reply other threads:[~2009-03-13 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 18:25 [Qemu-devel] [PATCH] make qemu_announce_self handle non contiguous net tables Marcelo Tosatti
2009-03-13 16:19 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BA87A1.9080605@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).