From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LiqW6-0002Kn-61
	for qemu-devel@nongnu.org; Sun, 15 Mar 2009 09:36:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LiqW1-0002Dd-2W
	for qemu-devel@nongnu.org; Sun, 15 Mar 2009 09:36:37 -0400
Received: from [199.232.76.173] (port=40869 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LiqW0-0002DS-T3
	for qemu-devel@nongnu.org; Sun, 15 Mar 2009 09:36:32 -0400
Received: from mx2.redhat.com ([66.187.237.31]:47279)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1LiqW0-0000Xs-9J
	for qemu-devel@nongnu.org; Sun, 15 Mar 2009 09:36:32 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2FDaUJt023152
	for <qemu-devel@nongnu.org>; Sun, 15 Mar 2009 09:36:30 -0400
Message-ID: <49BD045D.6030601@redhat.com>
Date: Sun, 15 Mar 2009 15:36:29 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/6] change vectored block I/O API to plain
	iovecs
References: <20090314192701.GA3497@lst.de>
	<20090314192828.GB3717@lst.de>	<49BCF79D.8050103@redhat.com>
	<49BD0080.6050709@codemonkey.ws>
In-Reply-To: <49BD0080.6050709@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori wrote:
>> virtio gets its iovecs through a hacky (and incorrect, try >=4G) 
>> method.  IMO virtio should be fixed to use the dma api, at which 
>> point it will start to use QEMUIOVector anyway,
>
> >= 4GB should work fine in virtio.  It basically replicates the DMA 
> API today.  It doesn't handle MMIO memory though.
>

Right.  I saw phys_ram_base somewhere and jumped to conclusions.  Sorry 
about the noise.

Still, it should use the dma api to avoid code duplication.

-- 
error compiling committee.c: too many arguments to function