From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lirmq-0007Iv-SL for qemu-devel@nongnu.org; Sun, 15 Mar 2009 10:58:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lirmm-0007Gl-Ac for qemu-devel@nongnu.org; Sun, 15 Mar 2009 10:58:00 -0400 Received: from [199.232.76.173] (port=53751 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lirmm-0007Ge-2e for qemu-devel@nongnu.org; Sun, 15 Mar 2009 10:57:56 -0400 Received: from mx2.redhat.com ([66.187.237.31]:53767) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lirml-0002k8-KY for qemu-devel@nongnu.org; Sun, 15 Mar 2009 10:57:55 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2FEvs0N004937 for ; Sun, 15 Mar 2009 10:57:54 -0400 Message-ID: <49BD1771.9040905@redhat.com> Date: Sun, 15 Mar 2009 16:57:53 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] Add specialized block driver scsi generic API References: <1236862631-22918-1-git-send-email-avi@redhat.com> <1236862631-22918-2-git-send-email-avi@redhat.com> <20090314143327.GA26791@lst.de> <49BD0892.3060604@redhat.com> <20090315144313.GA30986@lst.de> In-Reply-To: <20090315144313.GA30986@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Christoph Hellwig wrote: > The patch series (now posted) makes all aio APIs use iovecs. The > current non-iovec based SG API would require some nasty shims allocating > nested aiocbs. Or we could just make the sg aio methods fake-ioveced > which is the solution I had before your split, always adding a > one-element iovec to the scsi-generic request structure. > I'd go for having everything vectored. It's how non-1962 hardware works. -- error compiling committee.c: too many arguments to function