From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LjAr4-0000Rn-Te
	for qemu-devel@nongnu.org; Mon, 16 Mar 2009 07:19:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LjAqz-0000NI-96
	for qemu-devel@nongnu.org; Mon, 16 Mar 2009 07:19:37 -0400
Received: from [199.232.76.173] (port=38687 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LjAqz-0000N6-4O
	for qemu-devel@nongnu.org; Mon, 16 Mar 2009 07:19:33 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:60888)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1LjAqy-0004P3-PG
	for qemu-devel@nongnu.org; Mon, 16 Mar 2009 07:19:32 -0400
Received: from [10.80.225.184] ([10.80.225.184])
	by smtp01.ad.xensource.com (8.13.1/8.13.1) with ESMTP id n2GBJBl0022121
	for <qemu-devel@nongnu.org>; Mon, 16 Mar 2009 04:19:12 -0700
Message-ID: <49BE354C.7010806@eu.citrix.com>
Date: Mon, 16 Mar 2009 11:17:32 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] vnc: shared buffer: skip some optimizations.
References: <49B7CE21.4030104@redhat.com>	<49B7DC25.6010500@codemonkey.ws>	<49B9697C.5020607@redhat.com>	<49BA4B9B.7040208@eu.citrix.com>	<49BE0F50.5000009@redhat.com>	<49BE299F.1030802@eu.citrix.com>
	<49BE32CB.70405@redhat.com>
In-Reply-To: <49BE32CB.70405@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Gerd Hoffmann wrote:

> (b) doesn't set the 'to send' bit.  It clears the 'to send' bit for
> screen areas which are not modified.
> 
> You have two possible effects:
>  * screen update is sent twice.
>  * screen update is *not* sent.
> 
> The second causes persistent screen corruptions, it is not fixed up by
> the next refresh.
> 
> Wanna have a screen shot?
> 

Ok, ok I believe you :)

Your patch is fine for me then.