From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LjD2Y-0001Kd-7O for qemu-devel@nongnu.org; Mon, 16 Mar 2009 09:39:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LjD2T-00018m-2d for qemu-devel@nongnu.org; Mon, 16 Mar 2009 09:39:37 -0400 Received: from [199.232.76.173] (port=40512 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LjD2S-00018X-Uo for qemu-devel@nongnu.org; Mon, 16 Mar 2009 09:39:33 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58027) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LjD2S-000621-HY for qemu-devel@nongnu.org; Mon, 16 Mar 2009 09:39:32 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2GDdVei019952 for ; Mon, 16 Mar 2009 09:39:31 -0400 Message-ID: <49BE5692.1030509@redhat.com> Date: Mon, 16 Mar 2009 15:39:30 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/5] Convert vectored aio emulation to use a dedicated pool References: <1237209071-26942-1-git-send-email-avi@redhat.com> <1237209071-26942-3-git-send-email-avi@redhat.com> <20090316133202.GB4200@lst.de> In-Reply-To: <20090316133202.GB4200@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Christoph Hellwig wrote: > On Mon, Mar 16, 2009 at 03:11:08PM +0200, Avi Kivity wrote: > >> This allows us to remove a hack in the vectored aio cancellation code. >> > > Note that patch my switch to the aio_readv/writev methods will get rid of > this whole double aiocb indirection in a very natural way. > Right, when you don't use a synthetic aiocb, the need goes away. We'll still have one for the block-dma-helpers, due to the need to fragment a request when bounce resources are exhausted. -- error compiling committee.c: too many arguments to function