From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LkM3i-0007gC-Od for qemu-devel@nongnu.org; Thu, 19 Mar 2009 13:29:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LkM3d-0007aT-3T for qemu-devel@nongnu.org; Thu, 19 Mar 2009 13:29:33 -0400 Received: from [199.232.76.173] (port=55213 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LkM3c-0007aF-Us for qemu-devel@nongnu.org; Thu, 19 Mar 2009 13:29:29 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:41317) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LkM3c-0002T2-OY for qemu-devel@nongnu.org; Thu, 19 Mar 2009 13:29:28 -0400 Received: from [10.80.225.184] ([10.80.225.184]) by smtp01.ad.xensource.com (8.13.1/8.13.1) with ESMTP id n2JHTMm0001939 for ; Thu, 19 Mar 2009 10:29:23 -0700 Message-ID: <49C28020.5060503@eu.citrix.com> Date: Thu, 19 Mar 2009 17:25:52 +0000 From: Stefano Stabellini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/3] vnc: throttle screen updates. References: <49C11CAC.3060405@redhat.com> In-Reply-To: <49C11CAC.3060405@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" Gerd Hoffmann wrote: > Hi, > > This patch makes the vnc server code skip screen refreshes in case > there is data in the output buffer. This reduces the refresh rate to > throttle the bandwidth needed in case the network link is saturated. > I like the idea behind this patch, but I would make force_update an unsigned integer instead of a boolean, incrementing it every time we get a framebuffer_update_request and decrementing it every time we send a reply. Secondly we could even move vga_hw_update after: if (vs->output.offset && !vs->audio_cap && !vs->force_update)