From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LkiZn-000706-Q7
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 13:32:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LkiZk-0006yB-0Z
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 13:32:11 -0400
Received: from [199.232.76.173] (port=52910 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LkiZj-0006y6-NE
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 13:32:07 -0400
Received: from e35.co.us.ibm.com ([32.97.110.153]:37056)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LkiZj-0004wo-BP
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 13:32:07 -0400
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com
	[9.17.195.227])
	by e35.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2KHRZMt015401
	for <qemu-devel@nongnu.org>; Fri, 20 Mar 2009 11:27:35 -0600
Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n2KHW57Q045040
	for <qemu-devel@nongnu.org>; Fri, 20 Mar 2009 11:32:05 -0600
Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1])
	by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n2KHW5qH025207
	for <qemu-devel@nongnu.org>; Fri, 20 Mar 2009 11:32:05 -0600
Received: from squirrel.codemonkey.ws (sig-9-65-237-170.mts.ibm.com
	[9.65.237.170])
	by d03av03.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	n2KHW4ff025174
	for <qemu-devel@nongnu.org>; Fri, 20 Mar 2009 11:32:05 -0600
Message-ID: <49C3D314.6000307@us.ibm.com>
Date: Fri, 20 Mar 2009 12:32:04 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] x86: Add NULL check to lsl
References: <49BE91C7.402@siemens.com>
In-Reply-To: <49BE91C7.402@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jan Kiszka wrote:
> According to the Intel specs, lsl performs a check against NULL for the
> provided selector, just like lar does. helper_lar() includes the
> corresponding code, helper_lsl() was lacking it so far.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>   

Applied to trunk and stable.  Thanks.

Regards,

Anthony Liguori

> ---
>
>  target-i386/op_helper.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
> index 25e079b..be09263 100644
> --- a/target-i386/op_helper.c
> +++ b/target-i386/op_helper.c
> @@ -3241,6 +3241,8 @@ target_ulong helper_lsl(target_ulong selector1)
>  
>      selector = selector1 & 0xffff;
>      eflags = helper_cc_compute_all(CC_OP);
> +    if ((selector & 0xfffc) == 0)
> +        goto fail;
>      if (load_segment(&e1, &e2, selector) != 0)
>          goto fail;
>      rpl = selector & 3;
>
>
>
>